Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1055133003: Oilpan: have Storage objects reside on the heap by default. (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: have Storage objects reside on the heap by default. R=haraken BUG=479467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194451

Patch Set 1 #

Patch Set 2 : incorrect to use GC as base DOMWindowStorageController always #

Patch Set 3 : reinstate DOMWindowStorage transition type for its GC base class #

Patch Set 4 : trivial cl footprint reduction #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -54 lines) Patch
M Source/bindings/modules/v8/DictionaryHelperForModules.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/storage/DOMWindowStorage.h View 1 2 3 1 chunk +3 lines, -3 lines 2 comments Download
M Source/modules/storage/DOMWindowStorage.cpp View 1 2 5 chunks +18 lines, -17 lines 0 comments Download
M Source/modules/storage/DOMWindowStorageController.h View 1 2 3 1 chunk +2 lines, -2 lines 1 comment Download
M Source/modules/storage/DOMWindowStorageController.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/storage/InspectorDOMStorageAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/storage/InspectorDOMStorageAgent.cpp View 5 chunks +4 lines, -5 lines 0 comments Download
M Source/modules/storage/Storage.h View 3 chunks +5 lines, -6 lines 0 comments Download
M Source/modules/storage/Storage.cpp View 3 chunks +7 lines, -5 lines 0 comments Download
M Source/modules/storage/Storage.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/storage/StorageArea.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/storage/StorageArea.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/storage/StorageEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/storage/StorageNamespace.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/storage/StorageNamespace.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
5 years, 8 months ago (2015-04-26 08:04:02 UTC) #2
haraken
LGTM Add a bug number. https://codereview.chromium.org/1055133003/diff/60001/Source/modules/storage/DOMWindowStorage.h File Source/modules/storage/DOMWindowStorage.h (right): https://codereview.chromium.org/1055133003/diff/60001/Source/modules/storage/DOMWindowStorage.h#newcode37 Source/modules/storage/DOMWindowStorage.h:37: RawPtrWillBeMember<LocalDOMWindow> m_window; Not related ...
5 years, 8 months ago (2015-04-26 08:55:36 UTC) #4
sof
https://codereview.chromium.org/1055133003/diff/60001/Source/modules/storage/DOMWindowStorage.h File Source/modules/storage/DOMWindowStorage.h (right): https://codereview.chromium.org/1055133003/diff/60001/Source/modules/storage/DOMWindowStorage.h#newcode37 Source/modules/storage/DOMWindowStorage.h:37: RawPtrWillBeMember<LocalDOMWindow> m_window; On 2015/04/26 08:55:36, haraken wrote: > > ...
5 years, 8 months ago (2015-04-26 14:16:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1055133003/60001
5 years, 8 months ago (2015-04-26 14:18:07 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-26 14:21:13 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194451

Powered by Google App Engine
This is Rietveld 408576698