Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: Source/modules/storage/Storage.h

Issue 1055133003: Oilpan: have Storage objects reside on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: trivial cl footprint reduction Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 14 matching lines...) Expand all
25 25
26 #ifndef Storage_h 26 #ifndef Storage_h
27 #define Storage_h 27 #define Storage_h
28 28
29 #include "bindings/core/v8/ScriptWrappable.h" 29 #include "bindings/core/v8/ScriptWrappable.h"
30 #include "bindings/core/v8/V8Binding.h" 30 #include "bindings/core/v8/V8Binding.h"
31 #include "core/frame/DOMWindowProperty.h" 31 #include "core/frame/DOMWindowProperty.h"
32 #include "modules/storage/StorageArea.h" 32 #include "modules/storage/StorageArea.h"
33 #include "platform/heap/Handle.h" 33 #include "platform/heap/Handle.h"
34 #include "wtf/Forward.h" 34 #include "wtf/Forward.h"
35 #include "wtf/RefCounted.h"
36 #include "wtf/RefPtr.h" 35 #include "wtf/RefPtr.h"
37 36
38 namespace blink { 37 namespace blink {
39 38
40 class ExceptionState; 39 class ExceptionState;
41 class LocalFrame; 40 class LocalFrame;
42 41
43 class Storage final : public RefCountedWillBeGarbageCollected<Storage>, public S criptWrappable, public DOMWindowProperty { 42 class Storage final : public GarbageCollectedFinalized<Storage>, public ScriptWr appable, public DOMWindowProperty {
44 DEFINE_WRAPPERTYPEINFO(); 43 DEFINE_WRAPPERTYPEINFO();
45 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Storage); 44 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Storage);
46 DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED(Storage);
47 public: 45 public:
48 static PassRefPtrWillBeRawPtr<Storage> create(LocalFrame*, PassOwnPtrWillBeR awPtr<StorageArea>); 46 static Storage* create(LocalFrame*, StorageArea*);
47 virtual ~Storage();
49 48
50 unsigned length(ExceptionState& ec) const { return m_storageArea->length(ec, m_frame); } 49 unsigned length(ExceptionState& ec) const { return m_storageArea->length(ec, m_frame); }
51 String key(unsigned index, ExceptionState& ec) const { return m_storageArea- >key(index, ec, m_frame); } 50 String key(unsigned index, ExceptionState& ec) const { return m_storageArea- >key(index, ec, m_frame); }
52 String getItem(const String& key, ExceptionState& ec) const { return m_stora geArea->getItem(key, ec, m_frame); } 51 String getItem(const String& key, ExceptionState& ec) const { return m_stora geArea->getItem(key, ec, m_frame); }
53 void setItem(const String& key, const String& value, ExceptionState& ec) { m _storageArea->setItem(key, value, ec, m_frame); } 52 void setItem(const String& key, const String& value, ExceptionState& ec) { m _storageArea->setItem(key, value, ec, m_frame); }
54 void removeItem(const String& key, ExceptionState& ec) { m_storageArea->remo veItem(key, ec, m_frame); } 53 void removeItem(const String& key, ExceptionState& ec) { m_storageArea->remo veItem(key, ec, m_frame); }
55 void clear(ExceptionState& ec) { m_storageArea->clear(ec, m_frame); } 54 void clear(ExceptionState& ec) { m_storageArea->clear(ec, m_frame); }
56 bool contains(const String& key, ExceptionState& ec) const { return m_storag eArea->contains(key, ec, m_frame); } 55 bool contains(const String& key, ExceptionState& ec) const { return m_storag eArea->contains(key, ec, m_frame); }
57 56
58 StorageArea* area() const { return m_storageArea.get(); } 57 StorageArea* area() const { return m_storageArea.get(); }
59 58
60 String anonymousIndexedGetter(unsigned, ExceptionState&); 59 String anonymousIndexedGetter(unsigned, ExceptionState&);
61 String anonymousNamedGetter(const AtomicString&, ExceptionState&); 60 String anonymousNamedGetter(const AtomicString&, ExceptionState&);
62 bool anonymousNamedSetter(const AtomicString& name, const AtomicString& valu e, ExceptionState&); 61 bool anonymousNamedSetter(const AtomicString& name, const AtomicString& valu e, ExceptionState&);
63 bool anonymousIndexedSetter(unsigned, const AtomicString&, ExceptionState&); 62 bool anonymousIndexedSetter(unsigned, const AtomicString&, ExceptionState&);
64 DeleteResult anonymousNamedDeleter(const AtomicString&, ExceptionState&); 63 DeleteResult anonymousNamedDeleter(const AtomicString&, ExceptionState&);
65 DeleteResult anonymousIndexedDeleter(unsigned, ExceptionState&); 64 DeleteResult anonymousIndexedDeleter(unsigned, ExceptionState&);
66 void namedPropertyEnumerator(Vector<String>&, ExceptionState&); 65 void namedPropertyEnumerator(Vector<String>&, ExceptionState&);
67 bool namedPropertyQuery(const AtomicString&, ExceptionState&); 66 bool namedPropertyQuery(const AtomicString&, ExceptionState&);
68 67
69 DECLARE_VIRTUAL_TRACE(); 68 DECLARE_VIRTUAL_TRACE();
70 69
71 private: 70 private:
72 Storage(LocalFrame*, PassOwnPtrWillBeRawPtr<StorageArea>); 71 Storage(LocalFrame*, StorageArea*);
73 72
74 OwnPtrWillBeMember<StorageArea> m_storageArea; 73 Member<StorageArea> m_storageArea;
75 }; 74 };
76 75
77 } // namespace blink 76 } // namespace blink
78 77
79 #endif // Storage_h 78 #endif // Storage_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698