Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 105493002: Use base namespace for string16 in chrome/renderer. (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
Reviewers:
sky
CC:
chromium-reviews, skanuj+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, Ilya Sherman, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, benquan, dominich, rouslan+autofillwatch_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, rpetterson, dyu1, rouslan+spellwatch_chromium.org, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, Jered, donnd+watch_chromium.org, David Black, Dane Wallinga, samarth+watch_chromium.org, estade+watch_chromium.org
Visibility:
Public.

Description

Use base namespace for string16 in chrome/renderer. TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238804

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -270 lines) Patch
M chrome/renderer/autofill/autofill_renderer_browsertest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_browsertest.cc View 24 chunks +43 lines, -43 lines 0 comments Download
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/renderer/autofill/password_generation_agent_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/renderer/extensions/extension_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/mock_printer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/net/net_error_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.h View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 9 chunks +10 lines, -9 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_term_feature_extractor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_term_feature_extractor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc View 7 chunks +9 lines, -7 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 7 chunks +11 lines, -9 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/spellchecker/cocoa_spelling_engine_mac.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/renderer/spellchecker/cocoa_spelling_engine_mac.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/spellchecker/custom_dictionary_engine.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/custom_dictionary_engine.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/custom_dictionary_engine_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/hunspell_engine.h View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/renderer/spellchecker/hunspell_engine.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck.cc View 7 chunks +11 lines, -10 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_language.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_language.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 19 chunks +24 lines, -24 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator.h View 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator.cc View 1 9 chunks +15 lines, -9 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/renderer/spellchecker/spelling_engine.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/translate/translate_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/translate/translate_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/validation_message_agent.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/web_apps.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/web_apps.cc View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
7 years ago (2013-12-04 20:55:30 UTC) #1
brettw
7 years ago (2013-12-04 22:50:11 UTC) #2
Message was sent while issue was closed. 
Committed patchset #2 manually as r238804 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698