chrome/renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc - Issue 105493002: Use base namespace for string16 in chrome/renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc

Issue 105493002: Use base namespace for string16 in chrome/renderer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/spellchecker/spellcheck_provider.cc ('k') | chrome/renderer/spellchecker/spellcheck_provider_mac_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc

diff --git a/chrome/renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc b/chrome/renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc

index a08fb785442277709a9d05593136429c6768fdbf..eb92ceb78d3d1fec45252c8c6661af781a3c074b 100644

--- a/chrome/renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc

+++ b/chrome/renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc

@@ -132,14 +132,14 @@ TEST_F(SpellCheckProviderTest, CancelUnnecessaryRequests) {

TEST_F(SpellCheckProviderTest, CompleteNecessaryRequests) {

FakeTextCheckingCompletion completion;

- string16 text = ASCIIToUTF16("Icland is an icland ");

+ base::string16 text = ASCIIToUTF16("Icland is an icland ");

provider_.RequestTextChecking(

blink::WebString(text), &completion, std::vector<SpellCheckMarker>());

EXPECT_EQ(0U, completion.cancellation_count_) << "Should finish checking \""

<< text << "\"";

const int kSubstringLength = 18;

- string16 substring = text.substr(0, kSubstringLength);

+ base::string16 substring = text.substr(0, kSubstringLength);

provider_.RequestTextChecking(blink::WebString(substring),

&completion,

std::vector<SpellCheckMarker>());