Issue 105473007: Stop building Chrome Frame.

Issue 105473007: Stop building Chrome Frame. (Closed)

Created:
6 years, 11 months ago by grt (UTC plus 2)

Modified:
6 years, 11 months ago

Reviewers:
Lei Zhang, robertshield

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Stop building Chrome Frame. BUG=316496 TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243119

Patch Set 1 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -150 lines)			Patch
M	.gitignore	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	build/all.gyp	View	8 chunks	+0 lines, -44 lines	0 comments	Download
M	chrome/chrome_installer.gypi	View	3 chunks	+0 lines, -12 lines	0 comments	Download
M	chrome/installer/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/installer/mini_installer/chrome.release	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/installer/setup/install_worker.cc	View	4 chunks	+4 lines, -36 lines	0 comments	Download
M	chrome/tools/build/win/FILES.cfg	View	2 chunks	+0 lines, -49 lines	0 comments	Download
M	chrome/tools/check_grd_for_unused_strings.py	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/105473007/120001

6 years, 11 months ago (2014-01-06 15:38:02 UTC) #3

commit-bot: I haz the power

Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43336

6 years, 11 months ago (2014-01-06 15:56:03 UTC) #4

grt (UTC plus 2)

TBR thestig@ for OWNERS check of chrome/tools/check_grd_for_unused_strings.py

6 years, 11 months ago (2014-01-06 16:01:48 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/105473007/120001

6 years, 11 months ago (2014-01-06 16:02:06 UTC) #6

Lei Zhang

On 2014/01/06 16:01:48, grt wrote: > TBR thestig@ for OWNERS check of chrome/tools/check_grd_for_unused_strings.py chrome/tools/check_grd_for_unused_strings.py lgtm, ...

6 years, 11 months ago (2014-01-07 00:06:43 UTC) #8

grt (UTC plus 2)

6 years, 11 months ago (2014-01-07 14:57:18 UTC) #9

Message was sent while issue was closed.

On 2014/01/07 00:06:43, Lei Zhang wrote:
> On 2014/01/06 16:01:48, grt wrote:
> > TBR thestig@ for OWNERS check of
chrome/tools/check_grd_for_unused_strings.py
> 
> chrome/tools/check_grd_for_unused_strings.py lgtm, please remember to add me
as
> a reviewer in the future, so I get an email for the CL.

Accidental omission. Will double-check in the future, thanks.

Expand Messages | Collapse Messages