Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5226)

Unified Diff: chrome/installer/setup/install_worker.cc

Issue 105473007: Stop building Chrome Frame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/mini_installer/chrome.release ('k') | chrome/tools/build/win/FILES.cfg » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/install_worker.cc
diff --git a/chrome/installer/setup/install_worker.cc b/chrome/installer/setup/install_worker.cc
index 16aebce0bb413c95e1bbc14dd799114ae7a22e5d..1713fe5884a2077c9cf9376eba5bce734372bab2 100644
--- a/chrome/installer/setup/install_worker.cc
+++ b/chrome/installer/setup/install_worker.cc
@@ -48,10 +48,6 @@
#include "chrome/installer/util/util_constants.h"
#include "chrome/installer/util/work_item_list.h"
-#if !defined(OMIT_CHROME_FRAME)
-#include "chrome_frame/chrome_tab.h"
-#endif
-
using base::ASCIIToWide;
using base::win::RegKey;
@@ -59,11 +55,6 @@ namespace installer {
namespace {
-enum ElevationPolicyId {
- CURRENT_ELEVATION_POLICY,
- OLD_ELEVATION_POLICY,
-};
-
// The version identifying the work done by setup.exe --configure-user-settings
// on user login by way of Active Setup. Increase this value if the work done
// in setup_main.cc's handling of kConfigureUserSettings changes and should be
@@ -77,37 +68,14 @@ const wchar_t kActiveSetupVersion[] = L"24,0,0,0";
const wchar_t kIELowRightsPolicyOldGuid[] =
L"{6C288DD7-76FB-4721-B628-56FAC252E199}";
-#if defined(OMIT_CHROME_FRAME)
-// For historical reasons, this GUID is the same as CLSID_ChromeFrame. Included
-// here to break the dependency on Chrome Frame when Chrome Frame is not being
-// built.
-// TODO(robertshield): Remove this when Chrome Frame works with Aura.
-const wchar_t kIELowRightsPolicyCurrentGuid[] =
- L"{E0A900DF-9611-4446-86BD-4B1D47E7DB2A}";
-#endif
-
const wchar_t kElevationPolicyKeyPath[] =
L"SOFTWARE\\Microsoft\\Internet Explorer\\Low Rights\\ElevationPolicy\\";
-void GetIELowRightsElevationPolicyKeyPath(ElevationPolicyId policy,
- base::string16* key_path) {
- DCHECK(policy == CURRENT_ELEVATION_POLICY || policy == OLD_ELEVATION_POLICY);
+void GetOldIELowRightsElevationPolicyKeyPath(base::string16* key_path) {
key_path->assign(kElevationPolicyKeyPath,
arraysize(kElevationPolicyKeyPath) - 1);
- if (policy == CURRENT_ELEVATION_POLICY) {
-#if defined(OMIT_CHROME_FRAME)
- key_path->append(kIELowRightsPolicyCurrentGuid,
- arraysize(kIELowRightsPolicyCurrentGuid) - 1);
-#else
- wchar_t cf_clsid[64];
- int len = StringFromGUID2(__uuidof(ChromeFrame), &cf_clsid[0],
- arraysize(cf_clsid));
- key_path->append(&cf_clsid[0], len - 1);
-#endif
- } else {
- key_path->append(kIELowRightsPolicyOldGuid,
- arraysize(kIELowRightsPolicyOldGuid)- 1);
- }
+ key_path->append(kIELowRightsPolicyOldGuid,
+ arraysize(kIELowRightsPolicyOldGuid)- 1);
}
// Local helper to call AddRegisterComDllWorkItems for all DLLs in a set of
@@ -1374,7 +1342,7 @@ void AddDeleteOldIELowRightsPolicyWorkItems(
DCHECK(install_list);
base::string16 key_path;
- GetIELowRightsElevationPolicyKeyPath(OLD_ELEVATION_POLICY, &key_path);
+ GetOldIELowRightsElevationPolicyKeyPath(&key_path);
install_list->AddDeleteRegKeyWorkItem(installer_state.root_key(), key_path);
}
« no previous file with comments | « chrome/installer/mini_installer/chrome.release ('k') | chrome/tools/build/win/FILES.cfg » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698