chrome/common/extensions/manifest_url_handler.h - Issue 105473003: Add explicit base namespace to string16 users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_url_handler.h

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc ('k') | chrome/common/extensions/manifest_url_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_url_handler.h

diff --git a/chrome/common/extensions/manifest_url_handler.h b/chrome/common/extensions/manifest_url_handler.h

index 181171e7f6652a199d513eb6a99275d896c47a99..057589b3cff35ba3ebbdd82f2f5ac5a01c6fb57a 100644

--- a/chrome/common/extensions/manifest_url_handler.h

+++ b/chrome/common/extensions/manifest_url_handler.h

@@ -67,7 +67,7 @@ class DevToolsPageHandler : public ManifestHandler {

DevToolsPageHandler();

virtual ~DevToolsPageHandler();

- virtual bool Parse(Extension* extension, string16* error) OVERRIDE;

+ virtual bool Parse(Extension* extension, base::string16* error) OVERRIDE;

private:

virtual const std::vector<std::string> Keys() const OVERRIDE;

@@ -81,7 +81,7 @@ class HomepageURLHandler : public ManifestHandler {

HomepageURLHandler();

virtual ~HomepageURLHandler();

- virtual bool Parse(Extension* extension, string16* error) OVERRIDE;

+ virtual bool Parse(Extension* extension, base::string16* error) OVERRIDE;

private:

virtual const std::vector<std::string> Keys() const OVERRIDE;

@@ -95,7 +95,7 @@ class UpdateURLHandler : public ManifestHandler {

UpdateURLHandler();

virtual ~UpdateURLHandler();

- virtual bool Parse(Extension* extension, string16* error) OVERRIDE;

+ virtual bool Parse(Extension* extension, base::string16* error) OVERRIDE;

private:

virtual const std::vector<std::string> Keys() const OVERRIDE;

@@ -109,7 +109,7 @@ class OptionsPageHandler : public ManifestHandler {

OptionsPageHandler();

virtual ~OptionsPageHandler();

- virtual bool Parse(Extension* extension, string16* error) OVERRIDE;

+ virtual bool Parse(Extension* extension, base::string16* error) OVERRIDE;

virtual bool Validate(const Extension* extension,

std::string* error,

std::vector<InstallWarning>* warnings) const OVERRIDE;

@@ -126,7 +126,7 @@ class URLOverridesHandler : public ManifestHandler {

URLOverridesHandler();

virtual ~URLOverridesHandler();

- virtual bool Parse(Extension* extension, string16* error) OVERRIDE;

+ virtual bool Parse(Extension* extension, base::string16* error) OVERRIDE;

private:

virtual const std::vector<std::string> Keys() const OVERRIDE;