chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc - Issue 105473003: Add explicit base namespace to string16 users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/theme_handler.cc ('k') | chrome/common/extensions/manifest_url_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

index b9737aaece1468f1d025921add3f1540f6ae1b3d..f7fbab99ceb7498d9576ba7c74de08e9de32416e 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

@@ -153,7 +153,7 @@ TEST_F(InitValueManifestTest, InitFromValueValidNameInRTL) {

scoped_refptr<Extension> extension(LoadAndExpectSuccess(

"init_valid_name_no_rtl.json"));

- string16 localized_name(ASCIIToUTF16("Dictionary (by Google)"));

+ base::string16 localized_name(ASCIIToUTF16("Dictionary (by Google)"));

base::i18n::AdjustStringForLocaleDirection(&localized_name);

EXPECT_EQ(localized_name, UTF8ToUTF16(extension->name()));

« no previous file with comments | « chrome/common/extensions/manifest_handlers/theme_handler.cc ('k') | chrome/common/extensions/manifest_url_handler.h » ('j') | no next file with comments »