Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc
diff --git a/chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc b/chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc
index acd1a81b61b3a2277c0db8f21d142f6ed43a2ab4..50b0345bdba3b456ab15ba34e0d18c8ee1d6b5e3 100644
--- a/chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc
+++ b/chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc
@@ -30,7 +30,7 @@ scoped_ptr<GURL> CreateManifestURL(const std::string& url) {
}
scoped_ptr<GURL> ParseHomepage(const ChromeSettingsOverrides& overrides,
- string16* error) {
+ base::string16* error) {
if (!overrides.homepage)
return scoped_ptr<GURL>();
scoped_ptr<GURL> manifest_url = CreateManifestURL(*overrides.homepage);
@@ -42,7 +42,7 @@ scoped_ptr<GURL> ParseHomepage(const ChromeSettingsOverrides& overrides,
}
std::vector<GURL> ParseStartupPage(const ChromeSettingsOverrides& overrides,
- string16* error) {
+ base::string16* error) {
std::vector<GURL> urls;
if (!overrides.startup_pages)
return urls;
@@ -64,7 +64,7 @@ std::vector<GURL> ParseStartupPage(const ChromeSettingsOverrides& overrides,
scoped_ptr<ChromeSettingsOverrides::Search_provider> ParseSearchEngine(
ChromeSettingsOverrides* overrides,
- string16* error) {
+ base::string16* error) {
if (!overrides->search_provider)
return scoped_ptr<ChromeSettingsOverrides::Search_provider>();
if (!CreateManifestURL(overrides->search_provider->favicon_url)) {
@@ -106,7 +106,8 @@ SettingsOverridesHandler::SettingsOverridesHandler() {}
SettingsOverridesHandler::~SettingsOverridesHandler() {}
-bool SettingsOverridesHandler::Parse(Extension* extension, string16* error) {
+bool SettingsOverridesHandler::Parse(Extension* extension,
+ base::string16* error) {
const base::Value* dict = NULL;
CHECK(extension->manifest()->Get(manifest_keys::kSettingsOverride, &dict));
scoped_ptr<ChromeSettingsOverrides> settings(

Powered by Google App Engine
This is Rietveld 408576698