Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_handlers/settings_overrides_handler. h" 5 #include "chrome/common/extensions/manifest_handlers/settings_overrides_handler. h"
6 6
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/common/extensions/permissions/settings_override_permission.h" 9 #include "chrome/common/extensions/permissions/settings_override_permission.h"
10 #include "extensions/common/error_utils.h" 10 #include "extensions/common/error_utils.h"
(...skipping 12 matching lines...) Expand all
23 23
24 scoped_ptr<GURL> CreateManifestURL(const std::string& url) { 24 scoped_ptr<GURL> CreateManifestURL(const std::string& url) {
25 scoped_ptr<GURL> manifest_url(new GURL(url)); 25 scoped_ptr<GURL> manifest_url(new GURL(url));
26 if (!manifest_url->is_valid() || 26 if (!manifest_url->is_valid() ||
27 !manifest_url->SchemeIsHTTPOrHTTPS()) 27 !manifest_url->SchemeIsHTTPOrHTTPS())
28 return scoped_ptr<GURL>(); 28 return scoped_ptr<GURL>();
29 return manifest_url.Pass(); 29 return manifest_url.Pass();
30 } 30 }
31 31
32 scoped_ptr<GURL> ParseHomepage(const ChromeSettingsOverrides& overrides, 32 scoped_ptr<GURL> ParseHomepage(const ChromeSettingsOverrides& overrides,
33 string16* error) { 33 base::string16* error) {
34 if (!overrides.homepage) 34 if (!overrides.homepage)
35 return scoped_ptr<GURL>(); 35 return scoped_ptr<GURL>();
36 scoped_ptr<GURL> manifest_url = CreateManifestURL(*overrides.homepage); 36 scoped_ptr<GURL> manifest_url = CreateManifestURL(*overrides.homepage);
37 if (!manifest_url) { 37 if (!manifest_url) {
38 *error = extensions::ErrorUtils::FormatErrorMessageUTF16( 38 *error = extensions::ErrorUtils::FormatErrorMessageUTF16(
39 manifest_errors::kInvalidHomepageOverrideURL, *overrides.homepage); 39 manifest_errors::kInvalidHomepageOverrideURL, *overrides.homepage);
40 } 40 }
41 return manifest_url.Pass(); 41 return manifest_url.Pass();
42 } 42 }
43 43
44 std::vector<GURL> ParseStartupPage(const ChromeSettingsOverrides& overrides, 44 std::vector<GURL> ParseStartupPage(const ChromeSettingsOverrides& overrides,
45 string16* error) { 45 base::string16* error) {
46 std::vector<GURL> urls; 46 std::vector<GURL> urls;
47 if (!overrides.startup_pages) 47 if (!overrides.startup_pages)
48 return urls; 48 return urls;
49 49
50 for (std::vector<std::string>::const_iterator i = 50 for (std::vector<std::string>::const_iterator i =
51 overrides.startup_pages->begin(); i != overrides.startup_pages->end(); 51 overrides.startup_pages->begin(); i != overrides.startup_pages->end();
52 ++i) { 52 ++i) {
53 scoped_ptr<GURL> manifest_url = CreateManifestURL(*i); 53 scoped_ptr<GURL> manifest_url = CreateManifestURL(*i);
54 if (!manifest_url) { 54 if (!manifest_url) {
55 *error = extensions::ErrorUtils::FormatErrorMessageUTF16( 55 *error = extensions::ErrorUtils::FormatErrorMessageUTF16(
56 manifest_errors::kInvalidStartupOverrideURL, *i); 56 manifest_errors::kInvalidStartupOverrideURL, *i);
57 } else { 57 } else {
58 urls.push_back(GURL()); 58 urls.push_back(GURL());
59 urls.back().Swap(manifest_url.get()); 59 urls.back().Swap(manifest_url.get());
60 } 60 }
61 } 61 }
62 return urls; 62 return urls;
63 } 63 }
64 64
65 scoped_ptr<ChromeSettingsOverrides::Search_provider> ParseSearchEngine( 65 scoped_ptr<ChromeSettingsOverrides::Search_provider> ParseSearchEngine(
66 ChromeSettingsOverrides* overrides, 66 ChromeSettingsOverrides* overrides,
67 string16* error) { 67 base::string16* error) {
68 if (!overrides->search_provider) 68 if (!overrides->search_provider)
69 return scoped_ptr<ChromeSettingsOverrides::Search_provider>(); 69 return scoped_ptr<ChromeSettingsOverrides::Search_provider>();
70 if (!CreateManifestURL(overrides->search_provider->favicon_url)) { 70 if (!CreateManifestURL(overrides->search_provider->favicon_url)) {
71 *error = extensions::ErrorUtils::FormatErrorMessageUTF16( 71 *error = extensions::ErrorUtils::FormatErrorMessageUTF16(
72 manifest_errors::kInvalidSearchEngineURL, 72 manifest_errors::kInvalidSearchEngineURL,
73 overrides->search_provider->favicon_url); 73 overrides->search_provider->favicon_url);
74 return scoped_ptr<ChromeSettingsOverrides::Search_provider>(); 74 return scoped_ptr<ChromeSettingsOverrides::Search_provider>();
75 } 75 }
76 if (!CreateManifestURL(overrides->search_provider->search_url)) { 76 if (!CreateManifestURL(overrides->search_provider->search_url)) {
77 *error = extensions::ErrorUtils::FormatErrorMessageUTF16( 77 *error = extensions::ErrorUtils::FormatErrorMessageUTF16(
(...skipping 21 matching lines...) Expand all
99 const SettingsOverrides* SettingsOverrides::Get( 99 const SettingsOverrides* SettingsOverrides::Get(
100 const Extension* extension) { 100 const Extension* extension) {
101 return static_cast<SettingsOverrides*>( 101 return static_cast<SettingsOverrides*>(
102 extension->GetManifestData(manifest_keys::kSettingsOverride)); 102 extension->GetManifestData(manifest_keys::kSettingsOverride));
103 } 103 }
104 104
105 SettingsOverridesHandler::SettingsOverridesHandler() {} 105 SettingsOverridesHandler::SettingsOverridesHandler() {}
106 106
107 SettingsOverridesHandler::~SettingsOverridesHandler() {} 107 SettingsOverridesHandler::~SettingsOverridesHandler() {}
108 108
109 bool SettingsOverridesHandler::Parse(Extension* extension, string16* error) { 109 bool SettingsOverridesHandler::Parse(Extension* extension,
110 base::string16* error) {
110 const base::Value* dict = NULL; 111 const base::Value* dict = NULL;
111 CHECK(extension->manifest()->Get(manifest_keys::kSettingsOverride, &dict)); 112 CHECK(extension->manifest()->Get(manifest_keys::kSettingsOverride, &dict));
112 scoped_ptr<ChromeSettingsOverrides> settings( 113 scoped_ptr<ChromeSettingsOverrides> settings(
113 ChromeSettingsOverrides::FromValue(*dict, error)); 114 ChromeSettingsOverrides::FromValue(*dict, error));
114 if (!settings) 115 if (!settings)
115 return false; 116 return false;
116 117
117 scoped_ptr<SettingsOverrides> info(new SettingsOverrides); 118 scoped_ptr<SettingsOverrides> info(new SettingsOverrides);
118 info->homepage = ParseHomepage(*settings, error); 119 info->homepage = ParseHomepage(*settings, error);
119 info->search_engine = ParseSearchEngine(settings.get(), error); 120 info->search_engine = ParseSearchEngine(settings.get(), error);
(...skipping 26 matching lines...) Expand all
146 extension->SetManifestData(manifest_keys::kSettingsOverride, 147 extension->SetManifestData(manifest_keys::kSettingsOverride,
147 info.release()); 148 info.release());
148 return true; 149 return true;
149 } 150 }
150 151
151 const std::vector<std::string> SettingsOverridesHandler::Keys() const { 152 const std::vector<std::string> SettingsOverridesHandler::Keys() const {
152 return SingleKey(manifest_keys::kSettingsOverride); 153 return SingleKey(manifest_keys::kSettingsOverride);
153 } 154 }
154 155
155 } // namespace extensions 156 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698