chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc - Issue 105473003: Add explicit base namespace to string16 users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.h ('k') | chrome/common/extensions/manifest_handlers/nacl_modules_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

diff --git a/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc b/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

index b1277d8094f5c8af25177bb1f28ee914b393e2b9..a1d4e406a881d38503e189112fb7e011b4fe9692 100644

--- a/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

+++ b/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

@@ -24,7 +24,8 @@ MinimumChromeVersionChecker::MinimumChromeVersionChecker() {

MinimumChromeVersionChecker::~MinimumChromeVersionChecker() {

}

-bool MinimumChromeVersionChecker::Parse(Extension* extension, string16* error) {

+bool MinimumChromeVersionChecker::Parse(Extension* extension,

+ base::string16* error) {

std::string minimum_version_string;

if (!extension->manifest()->GetString(keys::kMinimumChromeVersion,

&minimum_version_string)) {