Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_handlers/minimum_chrome_version_chec ker.h" 5 #include "chrome/common/extensions/manifest_handlers/minimum_chrome_version_chec ker.h"
6 6
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "base/version.h" 8 #include "base/version.h"
9 #include "chrome/common/chrome_version_info.h" 9 #include "chrome/common/chrome_version_info.h"
10 #include "extensions/common/error_utils.h" 10 #include "extensions/common/error_utils.h"
11 #include "extensions/common/extension.h" 11 #include "extensions/common/extension.h"
12 #include "extensions/common/manifest_constants.h" 12 #include "extensions/common/manifest_constants.h"
13 #include "grit/chromium_strings.h" 13 #include "grit/chromium_strings.h"
14 #include "ui/base/l10n/l10n_util.h" 14 #include "ui/base/l10n/l10n_util.h"
15 15
16 namespace extensions { 16 namespace extensions {
17 17
18 namespace keys = manifest_keys; 18 namespace keys = manifest_keys;
19 namespace errors = manifest_errors; 19 namespace errors = manifest_errors;
20 20
21 MinimumChromeVersionChecker::MinimumChromeVersionChecker() { 21 MinimumChromeVersionChecker::MinimumChromeVersionChecker() {
22 } 22 }
23 23
24 MinimumChromeVersionChecker::~MinimumChromeVersionChecker() { 24 MinimumChromeVersionChecker::~MinimumChromeVersionChecker() {
25 } 25 }
26 26
27 bool MinimumChromeVersionChecker::Parse(Extension* extension, string16* error) { 27 bool MinimumChromeVersionChecker::Parse(Extension* extension,
28 base::string16* error) {
28 std::string minimum_version_string; 29 std::string minimum_version_string;
29 if (!extension->manifest()->GetString(keys::kMinimumChromeVersion, 30 if (!extension->manifest()->GetString(keys::kMinimumChromeVersion,
30 &minimum_version_string)) { 31 &minimum_version_string)) {
31 *error = ASCIIToUTF16(errors::kInvalidMinimumChromeVersion); 32 *error = ASCIIToUTF16(errors::kInvalidMinimumChromeVersion);
32 return false; 33 return false;
33 } 34 }
34 35
35 Version minimum_version(minimum_version_string); 36 Version minimum_version(minimum_version_string);
36 if (!minimum_version.IsValid()) { 37 if (!minimum_version.IsValid()) {
37 *error = ASCIIToUTF16(errors::kInvalidMinimumChromeVersion); 38 *error = ASCIIToUTF16(errors::kInvalidMinimumChromeVersion);
(...skipping 15 matching lines...) Expand all
53 return false; 54 return false;
54 } 55 }
55 return true; 56 return true;
56 } 57 }
57 58
58 const std::vector<std::string> MinimumChromeVersionChecker::Keys() const { 59 const std::vector<std::string> MinimumChromeVersionChecker::Keys() const {
59 return SingleKey(keys::kMinimumChromeVersion); 60 return SingleKey(keys::kMinimumChromeVersion);
60 } 61 }
61 62
62 } // namespace extensions 63 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698