chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc - Issue 105473003: Add explicit base namespace to string16 users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_action/browser_action_handler.cc ('k') | chrome/common/extensions/api/extension_action/page_action_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc b/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

index 78aa04693880c10c757a5ffcbc03a8e8b5fdcce0..b2f223f79f822834ec3a2d5f36f5325f8ef21d61 100644

--- a/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

+++ b/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

@@ -103,7 +103,7 @@ TEST_F(BrowserActionManifestTest,

DictionaryBuilder().Set("19", std::string()) // Invalid value.

.Set("24", "icon24.png").Set("38", "icon38.png"))).Build();

- string16 error = ErrorUtils::FormatErrorMessageUTF16(

+ base::string16 error = ErrorUtils::FormatErrorMessageUTF16(

errors::kInvalidIconPath, "19");

LoadAndExpectError(Manifest(manifest_value.get(), "Invalid default icon"),

errors::kInvalidIconPath);