chrome/common/extensions/api/extension_action/browser_action_handler.cc - Issue 105473003: Add explicit base namespace to string16 users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/browser_action_handler.cc

Issue 105473003: Add explicit base namespace to string16 users. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_action/browser_action_handler.h ('k') | chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/browser_action_handler.cc

diff --git a/chrome/common/extensions/api/extension_action/browser_action_handler.cc b/chrome/common/extensions/api/extension_action/browser_action_handler.cc

index f87755485085a84ff08d41a69bed95ca4dafec10..1cf6b8b0e657550ecc94105f8d4a5a1cc4615921 100644

--- a/chrome/common/extensions/api/extension_action/browser_action_handler.cc

+++ b/chrome/common/extensions/api/extension_action/browser_action_handler.cc

@@ -24,7 +24,7 @@ BrowserActionHandler::~BrowserActionHandler() {

}

bool BrowserActionHandler::Parse(Extension* extension,

- string16* error) {

+ base::string16* error) {

const base::DictionaryValue* dict = NULL;

if (!extension->manifest()->GetDictionary(

manifest_keys::kBrowserAction, &dict)) {