upload.py will soon have dry run flags, read and use them in Rietveld

appengine/chromium_rietveld/codereview/views.py

 # Copyright 2008 Google Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
 #     http://www.apache.org/licenses/LICENSE-2.0
 #
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 157 matching lines @@
 
 class UploadForm(forms.Form):
 
   subject = forms.CharField(max_length=MAX_SUBJECT)
   description = forms.CharField(max_length=MAX_DESCRIPTION, required=False)
   project = forms.CharField(required=False)
   content_upload = forms.BooleanField(required=False)
   separate_patches = forms.BooleanField(required=False)
   base = forms.CharField(max_length=MAX_URL, required=False)
   target_ref = forms.CharField(max_length=MAX_URL, required=False)
+  cq_dry_run = forms.BooleanField(required=False)
   data = forms.FileField(required=False)
   issue = forms.IntegerField(required=False)
   reviewers = forms.CharField(max_length=MAX_REVIEWERS, required=False)
   cc = forms.CharField(max_length=MAX_CC, required=False)
   private = forms.BooleanField(required=False, initial=False)
   send_mail = forms.BooleanField(required=False)
   base_hashes = forms.CharField(required=False)
   commit = forms.BooleanField(required=False)
   repo_guid = forms.CharField(required=False, max_length=MAX_URL)
 
@@ skipping 1232 matching lines @@
 
   base = form.get_base()
   if base is None:
     return (None, None)
 
   first_issue_id, _ = models.Issue.allocate_ids(1)
   issue_key = ndb.Key(models.Issue, first_issue_id)
 
   project = form.cleaned_data['project']
   target_ref = _get_target_ref(form, issue_key, project)
+  cq_dry_run = form.cleaned_data.get('cq_dry_run', False)
+  cq_dry_run_triggered_by = account.email if cq_dry_run else ''
 
   issue = models.Issue(subject=form.cleaned_data['subject'],
                        description=form.cleaned_data['description'],
                        project=project,
                        base=base,
                        target_ref=target_ref,
                        repo_guid=form.cleaned_data.get('repo_guid', None),
                        reviewers=reviewers,
                        required_reviewers=required_reviewers,
                        cc=cc,
                        private=form.cleaned_data.get('private', False),
                        n_comments=0,
+                       cq_dry_run=cq_dry_run,
+                       cq_dry_run_last_triggered_by=cq_dry_run_triggered_by,
                        key=issue_key)
   issue.put()
 
   first_ps_id, _ = models.PatchSet.allocate_ids(1, parent=issue.key)
   ps_key = ndb.Key(models.PatchSet, first_ps_id, parent=issue.key)
   patchset = models.PatchSet(
     issue_key=issue.key, data=data, url=url, key=ps_key)
   patchset.put()
 
   if not separate_patches:
@@ skipping 114 matching lines @@
                                  if reviewer not in issue.required_reviewers]
     emails, _ = _get_emails(form, 'cc')
     if not form.is_valid():
       return None
     issue.cc += [cc for cc in emails if cc not in issue.cc]
   else:
     issue.reviewers, issue.required_reviewers = _get_emails(form, 'reviewers')
     issue.cc, _ = _get_emails(form, 'cc')
   issue.commit = False
   issue.target_ref = _get_target_ref(form, issue.key, issue.project)
+  issue.cq_dry_run = form.cleaned_data.get('cq_dry_run', False)
+  issue.cq_dry_run_last_triggered_by = account.email if issue.cq_dry_run else ''
   issue.calculate_updates_for()
   # New patchset has been uploaded, add to the approvers_to_notify list.
   approval_dict = json.loads(issue.reviewer_approval)
   if approval_dict:
     for approver in approval_dict:
       if approval_dict[approver] and approver not in issue.approvers_to_notify:
         issue.approvers_to_notify.append(approver)
   issue.put()
   # Log for auditing purposes.
   logging.info("Patchset id %s for issue %s has target_ref %s",
@@ skipping 3804 matching lines @@
     return HttpResponseNotFound()
   tops = []
   shame = []
   for i in data:
     if i.score == models.AccountStatsBase.NULL_SCORE:
       shame.append(i)
     else:
       tops.append(i)
   return respond(
       request, 'leaderboard.html', {'tops': tops, 'shame': shame, 'when': when})