Implement support for notification.vibrate

content/browser/notifications/notification_database_data_unittest.cc

Index: content/browser/notifications/notification_database_data_unittest.cc
diff --git a/content/browser/notifications/notification_database_data_unittest.cc b/content/browser/notifications/notification_database_data_unittest.cc
index f57bfa8f23a2923ad8f62a074e6c92c28958c8a0..b76f176a273e9888125559a1ec1c77940290784d 100644
--- a/content/browser/notifications/notification_database_data_unittest.cc
+++ b/content/browser/notifications/notification_database_data_unittest.cc
@@ -19,9 +19,14 @@ const char kNotificationLang[] = "nl";
 const char kNotificationBody[] = "Hello, world!";
 const char kNotificationTag[] = "my_tag";
 const char kNotificationIconUrl[] = "https://example.com/icon.png";
+const int kNotificationVibrationPattern[] = { 100, 200, 300 };
 const unsigned char kNotificationData[] = { 0xdf, 0xff, 0x0, 0x0, 0xff, 0xdf };
 
 TEST(NotificationDatabaseDataTest, SerializeAndDeserializeData) {
+  std::vector<int> vibration_pattern(
+      kNotificationVibrationPattern,
+      kNotificationVibrationPattern + arraysize(kNotificationVibrationPattern));
+
   std::vector<char> developer_data(
       kNotificationData, kNotificationData + arraysize(kNotificationData));
 
@@ -33,6 +38,7 @@ TEST(NotificationDatabaseDataTest, SerializeAndDeserializeData) {
   notification_data.body = base::ASCIIToUTF16(kNotificationBody);
   notification_data.tag = kNotificationTag;
   notification_data.icon = GURL(kNotificationIconUrl);
+  notification_data.vibration_pattern = vibration_pattern;
   notification_data.silent = true;
   notification_data.data = developer_data;
 
@@ -68,6 +74,14 @@ TEST(NotificationDatabaseDataTest, SerializeAndDeserializeData) {
   EXPECT_EQ(notification_data.body, copied_notification_data.body);
   EXPECT_EQ(notification_data.tag, copied_notification_data.tag);
   EXPECT_EQ(notification_data.icon, copied_notification_data.icon);
+
+  ASSERT_EQ(vibration_pattern.size(),

[dcheng, 2015/05/06 18:43:27]

You could do something like:
EXPECT_THAT(copied_notification_data.vibration_patterns,
ElementsAre(kNotificationVibrationPattern));

I don't feel strongly about this, but it might be slightly easier to write.

[Sanghyun Park, 2015/05/07 12:08:33]

Your suggestion is better than this code. :)
I'll change this

+            copied_notification_data.vibration_pattern.size());
+  for (size_t i = 0; i < vibration_pattern.size(); ++i) {
+    EXPECT_EQ(vibration_pattern[i],
+              copied_notification_data.vibration_pattern[i]);
+  }
+
   EXPECT_EQ(notification_data.silent, copied_notification_data.silent);
 
   ASSERT_EQ(developer_data.size(), copied_notification_data.data.size());