Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1386)

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.cc

Issue 1054573002: Implement support for notification.vibrate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/platform_notification_service_impl.cc
diff --git a/chrome/browser/notifications/platform_notification_service_impl.cc b/chrome/browser/notifications/platform_notification_service_impl.cc
index 5ecadd35d85819896607b4f7578caab6185eaa34..300f028d2cfb9b4ef9bf7f9f144191c60ba62cbd 100644
--- a/chrome/browser/notifications/platform_notification_service_impl.cc
+++ b/chrome/browser/notifications/platform_notification_service_impl.cc
@@ -295,6 +295,12 @@ Notification PlatformNotificationServiceImpl::CreateNotificationFromData(
notification.set_context_message(display_source);
notification.set_silent(notification_data.silent);
+#if defined(OS_ANDROID)
Peter Beverloo 2015/04/26 23:26:41 Sorry, I didn't mean that you had to make this And
Sanghyun Park 2015/04/27 14:00:00 Okay I'll change to PS1.
+ // This vibrate property currently has no effect on non-Android platforms.
+ // For reducing memory, virate is not set on non-Android platforms.
+ notification.set_vibrate(notification_data.vibrate);
+#endif
+
// Web Notifications do not timeout.
notification.set_never_timeout(true);

Powered by Google App Engine
This is Rietveld 408576698