Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1247)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/notifications/notification_database_data.proto

Issue 1054573002: Implement support for notification.vibrate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/notifications/platform_notification_service_impl.cc ('K') | « chrome/test/data/notifications/platform_notification_service.html ('k') | content/browser/notifications/notification_database_data_conversions.cc » ('j') | content/child/notifications/notification_data_conversions_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/notifications/notification_database_data.proto
diff --git a/content/browser/notifications/notification_database_data.proto b/content/browser/notifications/notification_database_data.proto
index 1fb6808ba80034500a02467364acd6fcda25cf2e..c09265a4c6a6e3f966c733428a7ec3415d7b9605 100644
--- a/content/browser/notifications/notification_database_data.proto
+++ b/content/browser/notifications/notification_database_data.proto
@@ -21,7 +21,7 @@ message NotificationDatabaseDataProto {
// Actual data payload of the notification. This message is the protocol
// buffer meant to serialize the content::PlatformNotificationData structure.
//
- // Next tag: 8
+ // Next tag: 10
message NotificationData {
enum Direction {
LEFT_TO_RIGHT = 0;
@@ -36,6 +36,7 @@ message NotificationDatabaseDataProto {
optional string icon = 6;
optional bool silent = 7;
optional bytes data = 8;
+ repeated int32 vibrate = 9 [packed=true];
Peter Beverloo 2015/04/26 23:26:41 Please keep the ordering synchronized with Platfor
Sanghyun Park 2015/04/27 14:00:00 Done.
}
optional NotificationData notification_data = 4;
« chrome/browser/notifications/platform_notification_service_impl.cc ('K') | « chrome/test/data/notifications/platform_notification_service.html ('k') | content/browser/notifications/notification_database_data_conversions.cc » ('j') | content/child/notifications/notification_data_conversions_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698