Implement support for notification.vibrate

ui/message_center/notification.h

Index: ui/message_center/notification.h
diff --git a/ui/message_center/notification.h b/ui/message_center/notification.h
index 060cddaef49dcc1156658e010abe6caa60683c0c..2c2186dde1c35216b5fcd6498218b2e2fe2f9066 100644
--- a/ui/message_center/notification.h
+++ b/ui/message_center/notification.h
@@ -50,6 +50,7 @@ class MESSAGE_CENTER_EXPORT RichNotificationData {
   std::vector<ButtonInfo> buttons;
   bool should_make_spoken_feedback_for_popup_updates;
   bool clickable;
+  std::vector<unsigned> vibrate;

[Avi (use Gerrit), 2015/04/21 17:28:47]

ditto

[Sanghyun Park, 2015/04/23 11:08:27]

Done.

   bool silent;
 };
 
@@ -104,6 +105,12 @@ class MESSAGE_CENTER_EXPORT Notification {
   int priority() const { return optional_fields_.priority; }
   void set_priority(int priority) { optional_fields_.priority = priority; }
 
+  // This vibrate property currently has no effect on non-Android platforms.
+  std::vector<unsigned> vibrate() const { return optional_fields_.vibrate; }

[Peter Beverloo, 2015/04/21 17:58:23]

const&

[Sanghyun Park, 2015/04/23 11:08:27]

Done.

+  void set_vibrate(const std::vector<unsigned>& vibrate) {

[Peter Beverloo, 2015/04/21 17:58:24]

Have you given a thought about vibration on non-Android platforms? We don't need
to fix it, but it'd be nice to eventually have an answer for it.

Blink currently limits the sequence to 99 entries, times 4 bytes plus a bit of
overhead, so the memory cost of supporting this on desktop would max out at ~400
bytes. That SGTM.

[Sanghyun Park, 2015/04/23 11:08:27]

I just think that this will be used in future.
For example, recently macbook's touchpad support vibrate, If this vibrate's APIs
are opened, this function will is useful.
But not now.
I didn't think like you, but your comment is very nice!!
I'll consider about your comments.
Thanks!

+    optional_fields_.vibrate = vibrate;
+  }
+
   // This property currently has no effect on non-Android platforms.
   bool silent() const { return optional_fields_.silent; }
   void set_silent(bool silent) { optional_fields_.silent = silent; }