Implement support for notification.vibrate

content/browser/notifications/notification_database_data_conversions.cc

Index: content/browser/notifications/notification_database_data_conversions.cc
diff --git a/content/browser/notifications/notification_database_data_conversions.cc b/content/browser/notifications/notification_database_data_conversions.cc
index d656f7dec6b5c9f6cacb22d13206a0acd09faa07..8794b5f1953dc7243d9bb21ebb790a8106ecd1da 100644
--- a/content/browser/notifications/notification_database_data_conversions.cc
+++ b/content/browser/notifications/notification_database_data_conversions.cc
@@ -38,6 +38,10 @@ bool DeserializeNotificationDatabaseData(const std::string& input,
   notification_data->body = base::UTF8ToUTF16(payload.body());
   notification_data->tag = payload.tag();
   notification_data->icon = GURL(payload.icon());
+
+  for (int i = 0; i < payload.vibrate_size(); ++i)

[Peter Beverloo, 2015/04/21 17:58:23]

google::protobuf::RepeatedField exposes iterators which can do this for us,
rather than iterating manually. Perhaps you'd prefer this?

if (payload.vibrate_size()) {
  notification_data->vibrate.assign(payload.vibrate().begin(),
                                    payload.vibrate().end());
}

[Sanghyun Park, 2015/04/23 11:08:26]

I'd like to use iterators too :)
I'll modify this.

+    notification_data->vibrate.push_back(payload.vibrate(i));
+
   notification_data->silent = payload.silent();
 
   if (payload.data().length()) {
@@ -67,6 +71,10 @@ bool SerializeNotificationDatabaseData(const NotificationDatabaseData& input,
   payload->set_body(base::UTF16ToUTF8(notification_data.body));
   payload->set_tag(notification_data.tag);
   payload->set_icon(notification_data.icon.spec());
+
+  for (size_t i = 0; i < notification_data.vibrate.size(); ++i)
+    payload->add_vibrate(notification_data.vibrate[i]);
+
   payload->set_silent(notification_data.silent);
 
   if (notification_data.data.size()) {