Implement support for notification.vibrate

content/public/common/platform_notification_data.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_PLATFORM_NOTIFICATION_DATA_H_
 #define CONTENT_PUBLIC_COMMON_PLATFORM_NOTIFICATION_DATA_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 33 matching lines @@
   // Contents of the notification.
   base::string16 body;
 
   // Tag of the notification. Notifications sharing both their origin and their
   // tag will replace the first displayed notification.
   std::string tag;
 
   // URL of the icon which is to be displayed with the notification.
   GURL icon;
 
+  // Vibrate pettern for notification.

[Avi (use Gerrit), 2015/04/21 17:28:47]

typo: pattern

[Peter Beverloo, 2015/04/21 17:58:23]

I'd prefer the following comment:

  // Vibration pattern for the notification, following the syntax of the
  // Vibration API. https://www.w3.org/TR/vibration/

[Sanghyun Park, 2015/04/23 11:08:27]

Done.

[Sanghyun Park, 2015/04/23 11:08:27]

Done.

+  std::vector<unsigned> vibrate;

[Avi (use Gerrit), 2015/04/21 17:28:47]

Use of unsigned ints is prohibited by the style guide. Use int.

https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Integer_Types

[Peter Beverloo, 2015/04/21 17:58:23]

We clamp the individual vibration indices to [0, blink::kVibrationDurationMax]
in Blink, which currently matches [0, 10000]. Using std::vector<int> here seems
good to me, but please change this consistently throughout the CL.

[Sanghyun Park, 2015/04/23 11:08:27]

Thanks for letting me know .
I didn't know about [1].
We'll refer [1]document in detail.

[1]
"https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Integer_Types".

+
   // Whether default notification indicators (sound, vibration, light) should
   // be suppressed.
   bool silent = false;
 
   // Developer-provided data associated with the notification, in the form of
   // a serialized string. Must not exceed |kMaximumDeveloperDataSize| bytes.
   std::vector<char> data;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_COMMON_PLATFORM_NOTIFICATION_DATA_H_