Issue 10545080: Optimize call sites that only ever have a single elements transition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10545080: Optimize call sites that only ever have a single elements transition (Closed)

Created:
8 years, 6 months ago by Zheng Liu

Modified:
8 years, 6 months ago

Reviewers:
Michael Starzinger, danno, Jakob Kummerow

CC:
v8-dev, zheng.z.liu

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Optimize call sites that only ever see a single elements transition BUG=v8:2141 imaging-desaturate performance improves

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -0 lines)			Patch
M	src/ic.cc	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	test/mjsunit/elements-kind.js	View	5 chunks	+14 lines, -0 lines	0 comments	Download
M	test/mjsunit/elements-transition-hoisting.js	View	6 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Zheng Liu

imaging-desaturate is 1.7X on my machine, running from default cmdline script. But some tests' expectation ...

8 years, 6 months ago (2012-06-08 04:28:23 UTC) #1

danno

8 years, 6 months ago (2012-06-08 11:47:19 UTC) #2

The changes needed to make sure that the Map's code cache is updated are
actually a more involved. I've reworked this patch into the following one and it
should subsume it: http://codereview.chromium.org/10532063/

Expand Messages | Collapse Messages