chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java - Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java

Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/test/android/javatests/src/org/chromium/base/test/util/TestFileUtil.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelAdapter.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderBookmarksUriTest.java » ('j') | tools/android/checkstyle/chromium-style-5.0.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java

index 3918475d9190cc2a888289974f7cd5414a7d286c..80564411679e029d97b6a67f14c184848e8d41e1 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java

@@ -35,11 +35,10 @@ public class ModalDialogTest extends ChromeShellTestBase {

private static final String TAG = "ModalDialogTest";

private static final String EMPTY_PAGE = UrlUtils.encodeHtmlDataUri(

"<html><title>Modal Dialog Test</title><p>Testcase.</p></title></html>");

- private static final String BEFORE_UNLOAD_URL = UrlUtils.encodeHtmlDataUri(

- "<html>" +

- "<head><script>window.onbeforeunload=function() {" +

- "return 'Are you sure?';" +

- "};</script></head></html>");

+ private static final String BEFORE_UNLOAD_URL = UrlUtils.encodeHtmlDataUri("<html>"

nyquist 2015/04/02 21:51:27 Wow. This is much more ugly, but OK.

+ + "<head><script>window.onbeforeunload=function() {"

+ + "return 'Are you sure?';"

+ + "};</script></head></html>");

@Override

public void setUp() throws Exception {