base/test/android/javatests/src/org/chromium/base/test/util/TestFileUtil.java - Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/android/javatests/src/org/chromium/base/test/util/TestFileUtil.java

Issue 1054203002: Enable NeedsBraces check and fix some checkstyle issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/javatests/src/org/chromium/base/ObserverListTest.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/WebappAuthenticator.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/test/android/javatests/src/org/chromium/base/test/util/TestFileUtil.java

diff --git a/base/test/android/javatests/src/org/chromium/base/test/util/TestFileUtil.java b/base/test/android/javatests/src/org/chromium/base/test/util/TestFileUtil.java

index ca6e73bb1c7d1ba152aa1d5f7edc6a735d2433fe..8765def89525d0a9f35aacedd7b40d77f9cb93d4 100644

--- a/base/test/android/javatests/src/org/chromium/base/test/util/TestFileUtil.java

+++ b/base/test/android/javatests/src/org/chromium/base/test/util/TestFileUtil.java

@@ -29,12 +29,12 @@ public class TestFileUtil {

Writer writer = null;

try {

writer = new OutputStreamWriter(new FileOutputStream(file), "UTF-8");

- writer.write("<html><meta charset=\"UTF-8\" />" +

- "<head><title>" + title + "</title></head>" +

- "<body>" +

- (body != null ? body : "") +

- "</body>" +

- "</html>");

+ writer.write("<html><meta charset=\"UTF-8\" />"

nyquist 2015/04/02 21:51:27 This is OK to cleanup, but I don't see what this w

+ + " <head><title>" + title + "</title></head>"

+ + " <body>"

+ + (body != null ? body : "")

+ + " </body>"

+ + " </html>");

} finally {

if (writer != null) {

writer.close();

@@ -61,8 +61,8 @@ public class TestFileUtil {

try {

File f = new File(fileName);

if (f.length() > sizeLimit) {

- throw new IOException("File " + fileName + " length " + f.length() +

- " exceeds limit " + sizeLimit);

+ throw new IOException("File " + fileName + " length " + f.length()

+ + " exceeds limit " + sizeLimit);

}

char[] buffer = new char[(int) f.length()];

reader = new InputStreamReader(new FileInputStream(f), "UTF-8");