Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1053953002: CSS Parser: Handle at-rules in declaration lists (Closed)

Created:
5 years, 8 months ago by Timothy Loh
Modified:
5 years, 8 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CSS Parser: Handle at-rules in declaration lists The css-syntax spec allows for at-rules in declaration lists. While we don't currently support any instances of this (the only case I know where this is used is in @page rules), we should still have the logic so we can correctly perform error recovery here. For example, ".a { @x { } left: 10px }" should still apply the left property since the at-rule ends at the }. http://dev.w3.org/csswg/css-syntax/#consume-list-of-declarations BUG=330389 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193243

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -4 lines) Patch
A LayoutTests/css-parser/at-rule-in-declaration-list.html View 1 1 chunk +50 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSParserImpl.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSParserImpl.cpp View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
5 years, 8 months ago (2015-04-02 04:10:57 UTC) #2
dstockwell
lgtm
5 years, 8 months ago (2015-04-07 04:18:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053953002/20001
5 years, 8 months ago (2015-04-07 04:20:11 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 05:42:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193243

Powered by Google App Engine
This is Rietveld 408576698