Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1053903002: Update libssl to NSS 3.18 RTM (Closed)

Created:
5 years, 8 months ago by Ryan Sleevi
Modified:
5 years, 8 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org, wtc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the bundled libssl to NSS 3.18 RTM BUG=469516 Committed: https://crrev.com/d5139059122edc3c22dfa0e60ad2e4d3167e27fc Cr-Commit-Position: refs/heads/master@{#323840}

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes #

Patch Set 3 : Prune patches #

Total comments: 10

Patch Set 4 : Review feedback #

Patch Set 5 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4515 lines, -4805 lines) Patch
M net/third_party/nss/README.chromium View 1 2 3 4 4 chunks +9 lines, -19 lines 0 comments Download
M net/third_party/nss/patches/aesgcmchromium.patch View 5 chunks +8 lines, -7 lines 0 comments Download
D net/third_party/nss/patches/alpnserver.patch View 1 2 1 chunk +0 lines, -349 lines 0 comments Download
M net/third_party/nss/patches/applypatches.sh View 1 1 chunk +21 lines, -27 lines 0 comments Download
M net/third_party/nss/patches/cachecerts.patch View 8 chunks +18 lines, -15 lines 0 comments Download
M net/third_party/nss/patches/cachelocks.patch View 1 2 3 11 chunks +36 lines, -32 lines 0 comments Download
M net/third_party/nss/patches/chacha20poly1305.patch View 1 2 3 16 chunks +57 lines, -50 lines 0 comments Download
M net/third_party/nss/patches/channelid.patch View 1 20 chunks +160 lines, -148 lines 0 comments Download
M net/third_party/nss/patches/cipherorder.patch View 1 2 3 4 chunks +36 lines, -32 lines 0 comments Download
M net/third_party/nss/patches/clientauth.patch View 20 chunks +104 lines, -98 lines 0 comments Download
M net/third_party/nss/patches/didhandshakeresume.patch View 2 chunks +10 lines, -8 lines 0 comments Download
D net/third_party/nss/patches/fallbackscsv.patch View 1 2 1 chunk +0 lines, -213 lines 0 comments Download
M net/third_party/nss/patches/getrequestedclientcerttypes.patch View 4 chunks +44 lines, -40 lines 0 comments Download
M net/third_party/nss/patches/nssrwlock.patch View 1 2 3 17 chunks +35 lines, -32 lines 0 comments Download
D net/third_party/nss/patches/paddingextvalue.patch View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M net/third_party/nss/patches/removebuildmetadata.patch View 1 chunk +3 lines, -3 lines 0 comments Download
M net/third_party/nss/patches/reorderextensions.patch View 1 1 chunk +16 lines, -20 lines 0 comments Download
M net/third_party/nss/patches/restartclientauth.patch View 3 chunks +31 lines, -27 lines 0 comments Download
M net/third_party/nss/patches/secitemarray.patch View 2 chunks +9 lines, -7 lines 0 comments Download
M net/third_party/nss/patches/secretexporterlocks.patch View 1 chunk +4 lines, -3 lines 0 comments Download
M net/third_party/nss/patches/sessioncache.patch View 1 2 3 2 chunks +23 lines, -20 lines 0 comments Download
M net/third_party/nss/patches/signedcertificatetimestamps.patch View 1 2 3 10 chunks +145 lines, -141 lines 0 comments Download
M net/third_party/nss/patches/suitebonly.patch View 2 chunks +6 lines, -5 lines 0 comments Download
M net/third_party/nss/patches/tls12chromium.patch View 5 chunks +16 lines, -13 lines 0 comments Download
M net/third_party/nss/patches/tlsunique.patch View 3 chunks +47 lines, -43 lines 0 comments Download
M net/third_party/nss/ssl/SSLerrs.h View 1 chunk +2 lines, -3 lines 0 comments Download
M net/third_party/nss/ssl/derive.c View 6 chunks +8 lines, -8 lines 0 comments Download
M net/third_party/nss/ssl/dtlscon.c View 32 chunks +285 lines, -269 lines 0 comments Download
M net/third_party/nss/ssl/ssl.h View 1 chunk +21 lines, -13 lines 0 comments Download
M net/third_party/nss/ssl/ssl3con.c View 1 2 3 54 chunks +181 lines, -137 lines 0 comments Download
M net/third_party/nss/ssl/ssl3ecc.c View 35 chunks +434 lines, -418 lines 0 comments Download
M net/third_party/nss/ssl/ssl3ext.c View 1 65 chunks +1129 lines, -1027 lines 0 comments Download
M net/third_party/nss/ssl/ssl3prot.h View 11 chunks +77 lines, -72 lines 0 comments Download
M net/third_party/nss/ssl/sslcon.c View 4 chunks +6 lines, -5 lines 0 comments Download
M net/third_party/nss/ssl/sslenum.c View 1 5 chunks +18 lines, -18 lines 0 comments Download
M net/third_party/nss/ssl/sslerr.h View 2 chunks +137 lines, -137 lines 0 comments Download
M net/third_party/nss/ssl/sslgathr.c View 1 chunk +0 lines, -28 lines 0 comments Download
M net/third_party/nss/ssl/sslimpl.h View 10 chunks +16 lines, -13 lines 0 comments Download
M net/third_party/nss/ssl/sslinfo.c View 2 chunks +14 lines, -14 lines 0 comments Download
M net/third_party/nss/ssl/sslnonce.c View 2 chunks +2 lines, -4 lines 0 comments Download
M net/third_party/nss/ssl/sslproto.h View 5 chunks +173 lines, -133 lines 0 comments Download
M net/third_party/nss/ssl/sslsecur.c View 2 chunks +4 lines, -6 lines 0 comments Download
M net/third_party/nss/ssl/sslsnce.c View 1 chunk +0 lines, -1 line 0 comments Download
M net/third_party/nss/ssl/sslsock.c View 86 chunks +1165 lines, -1128 lines 0 comments Download
M net/third_party/nss/ssl/sslt.h View 2 chunks +4 lines, -3 lines 0 comments Download
M net/third_party/nss/ssl/sslver.c View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Ryan Sleevi
David: For your review wtc: FYI There are three patches I seem to have botched, ...
5 years, 8 months ago (2015-04-02 23:35:40 UTC) #2
Ryan Sleevi
OK, good to review now. Patch snafus fixed, streamlined my process a little for generating ...
5 years, 8 months ago (2015-04-03 05:19:20 UTC) #3
davidben
lgtm. I'm super-dubious of this draft-TLS-1.3 code, but it's fine because we won't be enabling ...
5 years, 8 months ago (2015-04-03 19:06:18 UTC) #4
Ryan Sleevi
https://codereview.chromium.org/1053903002/diff/40001/net/third_party/nss/ssl/ssl3con.c File net/third_party/nss/ssl/ssl3con.c (right): https://codereview.chromium.org/1053903002/diff/40001/net/third_party/nss/ssl/ssl3con.c#newcode677 net/third_party/nss/ssl/ssl3con.c:677: case TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305: On 2015/04/03 19:06:18, David Benjamin wrote: > ...
5 years, 8 months ago (2015-04-03 20:48:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053903002/80001
5 years, 8 months ago (2015-04-03 20:54:18 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-03 22:47:06 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 22:52:48 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d5139059122edc3c22dfa0e60ad2e4d3167e27fc
Cr-Commit-Position: refs/heads/master@{#323840}

Powered by Google App Engine
This is Rietveld 408576698