Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1053823002: [Android] Disable fling cancel filtering in the GestureEventQueue (Closed)

Created:
5 years, 8 months ago by jdduke (slow)
Modified:
5 years, 8 months ago
Reviewers:
tdresser, boliu
CC:
chromium-reviews, darin-cc_chromium.org, jdduke+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Disable fling cancel filtering in the GestureEventQueue WebView has externally-managed flings that are invisible to the GestureEventQueue. This led to cases where we were dropping GestureFlingCancel events while a WebView-managed fling was still active. For now, disable GestureEventQueue filtering of GFC events on Android, instead using the "scroll in progress" bits from ContentViewCore to filter the events. When WebView's fling architecture is unified with that of the rest of Chrome, we can remove this exception. BUG=321141 Committed: https://crrev.com/f795840aee796fabc7267f9d33f159f5ace79cca Cr-Commit-Position: refs/heads/master@{#323510}

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Cleanup, working tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -2 lines) Patch
M content/browser/android/content_view_core_impl.cc View 1 2 2 chunks +10 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue.cc View 3 chunks +5 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue_unittest.cc View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/input_router_config_helper.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jdduke (slow)
+tdresser for content/browser/renderer_host/input changes. +boliu for content/browser/android and content/public/android changes.
5 years, 8 months ago (2015-04-01 20:21:26 UTC) #2
boliu
On 2015/04/01 20:21:26, jdduke wrote: > +tdresser for content/browser/renderer_host/input changes. > +boliu for content/browser/android and ...
5 years, 8 months ago (2015-04-01 21:11:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053823002/40001
5 years, 8 months ago (2015-04-02 15:44:55 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-02 16:41:22 UTC) #7
jdduke (slow)
On 2015/04/02 16:41:22, I haz the power (commit-bot) wrote: > Committed patchset #3 (id:40001) Sorry ...
5 years, 8 months ago (2015-04-02 16:46:15 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/f795840aee796fabc7267f9d33f159f5ace79cca Cr-Commit-Position: refs/heads/master@{#323510}
5 years, 8 months ago (2015-04-03 20:26:30 UTC) #9
tdresser
5 years, 8 months ago (2015-04-07 14:32:42 UTC) #10
Message was sent while issue was closed.
On 2015/04/03 20:26:30, I haz the power (commit-bot) wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/f795840aee796fabc7267f9d33f159f5ace79cca
> Cr-Commit-Position: refs/heads/master@{#323510}

No worries.
Postlanding LGTM.

Powered by Google App Engine
This is Rietveld 408576698