content/browser/renderer_host/input/input_router_config_helper.cc - Issue 1053823002: [Android] Disable fling cancel filtering in the GestureEventQueue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/input_router_config_helper.cc

Issue 1053823002: [Android] Disable fling cancel filtering in the GestureEventQueue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup, working tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/gesture_event_queue_unittest.cc ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/input_router_config_helper.cc

diff --git a/content/browser/renderer_host/input/input_router_config_helper.cc b/content/browser/renderer_host/input/input_router_config_helper.cc

index 3ed530f9ecab13794479af5aa801e7e8c3b48640..34c2a19218d79f3ad144e6b61751881e0f3f60b1 100644

--- a/content/browser/renderer_host/input/input_router_config_helper.cc

+++ b/content/browser/renderer_host/input/input_router_config_helper.cc

@@ -70,6 +70,12 @@ GestureEventQueue::Config GetGestureEventQueueConfig() {

base::TimeDelta::FromMilliseconds(

gfx::ViewConfiguration::GetLongPressTimeoutInMs());

+ // Android WebView may handle root layer flings itself, which prevents

+ // accurate fling cancel filtering (see |RenderWidgetCompositor::Initialize|).

+ // TODO(jdduke): Remove this exception when the WebView fling architecture

+ // is unified with the rest of Chrome, crbug.com/378984.

+ config.enable_fling_cancel_filtering = false;

return config;

}