Issue 10538092: [Chromoting] Sign the installer package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10538092: [Chromoting] Sign the installer package. (Closed)

Created:
8 years, 6 months ago by garykac

Modified:
8 years, 6 months ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[Chromoting] Sign the prefpane and installer package. Now that the Chromoting installer is built using Packages, we can build a "flat" installer and have it signed. A signed installer is required for OS X 10.8 (Mt Lion). This cl also signs the Chromoting prefpane. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141581

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -6 lines)			Patch
	M	remoting/host/installer/mac/ChromotingHost.pkgproj	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	remoting/host/installer/mac/do_signing.sh	View		4 chunks	+17 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

garykac

http://codereview.chromium.org/10538092/diff/1/remoting/host/installer/mac/ChromotingHost.pkgproj File remoting/host/installer/mac/ChromotingHost.pkgproj (right): http://codereview.chromium.org/10538092/diff/1/remoting/host/installer/mac/ChromotingHost.pkgproj#newcode700 remoting/host/installer/mac/ChromotingHost.pkgproj:700: <integer>0</integer> 0 = flat package

8 years, 6 months ago (2012-06-11 21:56:46 UTC) #1

Jamie

8 years, 6 months ago (2012-06-11 22:16:03 UTC) #2

lgtm, but can you update the description to state that it also adds signing for
the pref pane?

Expand Messages | Collapse Messages