Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: remoting/host/installer/mac/do_signing.sh

Issue 10538092: [Chromoting] Sign the installer package. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/installer/mac/do_signing.sh
===================================================================
--- remoting/host/installer/mac/do_signing.sh (revision 141423)
+++ remoting/host/installer/mac/do_signing.sh (working copy)
@@ -28,6 +28,7 @@
# Binaries to sign.
ME2ME_HOST='PrivilegedHelperTools/org.chromium.chromoting.me2me_host.app'
UNINSTALLER='Applications/@@HOST_UNINSTALLER_NAME@@.app'
+PREFPANE='PreferencePanes/org.chromium.chromoting.prefPane'
# The Chromoting Host installer is a meta-package that consists of 3
# components:
@@ -38,15 +39,18 @@
PKGPROJ_HOST='ChromotingHost.packproj'
PKGPROJ_HOST_SERVICE='ChromotingHostService.packproj'
PKGPROJ_HOST_UNINSTALLER='ChromotingHostUninstaller.packproj'
+
+ # Final (user-visible) mpkg name.
+ PKG_FINAL='@@HOST_PKG@@.mpkg'
else
PKGPROJ_HOST='ChromotingHost.pkgproj'
PKGPROJ_HOST_SERVICE='ChromotingHostService.pkgproj'
PKGPROJ_HOST_UNINSTALLER='ChromotingHostUninstaller.pkgproj'
+
+ # Final (user-visible) pkg name.
+ PKG_FINAL='@@HOST_PKG@@.pkg'
fi
-# Final (user-visible) mpkg name.
-PKG_FINAL='@@HOST_PKG@@.mpkg'
-
DMG_VOLUME_NAME='@@DMG_VOLUME_NAME@@'
DMG_FILE_NAME='@@DMG_FILE_NAME@@.dmg'
@@ -115,8 +119,17 @@
sign "${input_dir}/${ME2ME_HOST}" "${keychain}" "${id}"
sign "${input_dir}/${UNINSTALLER}" "${keychain}" "${id}"
+ sign "${input_dir}/${PREFPANE}" "${keychain}" "${id}"
}
+sign_installer() {
+ local input_dir="${1}"
+ local keychain="${2}"
+ local id="${3}"
+
+ sign "${input_dir}/${PKG_DIR}/${PKG_FINAL}" "${keychain}" "${id}"
+}
+
build_package() {
local pkg="${1}"
echo "Building .pkg from ${pkg}"
@@ -174,8 +187,7 @@
sign_binaries "${input_dir}" "${codesign_keychain}" "${codesign_id}"
build_packages "${input_dir}"
- # TODO(garykac): Sign final .mpkg once we've switched to Packages.
- # (crbug.com/127267)
+ sign_installer "${input_dir}" "${codesign_keychain}" "${codesign_id}"
build_dmg "${input_dir}" "${output_dir}"
cleanup

Powered by Google App Engine
This is Rietveld 408576698