Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1053793002: Remove the iOS deterministic builder. (Closed)

Created:
5 years, 8 months ago by Sébastien Marchand
Modified:
5 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Remove the iOS deterministic builder. BUG=383364 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294640

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove useless code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -315 lines) Patch
M masters/master.chromium.swarm/master.cfg View 3 chunks +1 line, -4 lines 0 comments Download
M masters/master.chromium.swarm/slaves.cfg View 1 chunk +0 lines, -8 lines 0 comments Download
M scripts/slave/recipes/swarming/deterministic_build.py View 1 3 chunks +1 line, -16 lines 0 comments Download
D scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_IOS_deterministic_build.json View 1 chunk +0 lines, -287 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Sébastien Marchand
PTAL.
5 years, 8 months ago (2015-04-01 19:16:30 UTC) #2
M-A Ruel
lgtm, thanks https://codereview.chromium.org/1053793002/diff/1/masters/master.chromium.swarm/slaves.cfg File masters/master.chromium.swarm/slaves.cfg (left): https://codereview.chromium.org/1053793002/diff/1/masters/master.chromium.swarm/slaves.cfg#oldcode106 masters/master.chromium.swarm/slaves.cfg:106: 'hostname': 'vm622-m1', Don't forget to file a ...
5 years, 8 months ago (2015-04-01 19:35:52 UTC) #3
Sébastien Marchand
https://codereview.chromium.org/1053793002/diff/1/masters/master.chromium.swarm/slaves.cfg File masters/master.chromium.swarm/slaves.cfg (left): https://codereview.chromium.org/1053793002/diff/1/masters/master.chromium.swarm/slaves.cfg#oldcode106 masters/master.chromium.swarm/slaves.cfg:106: 'hostname': 'vm622-m1', On 2015/04/01 19:35:52, M-A Ruel wrote: > ...
5 years, 8 months ago (2015-04-01 19:38:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053793002/1
5 years, 8 months ago (2015-04-01 19:38:34 UTC) #6
commit-bot: I haz the power
Presubmit check for 1053793002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-01 19:42:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053793002/20001
5 years, 8 months ago (2015-04-01 19:46:54 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 19:51:15 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294640

Powered by Google App Engine
This is Rietveld 408576698