Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: scripts/slave/recipes/swarming/deterministic_build.py

Issue 1053793002: Remove the iOS deterministic builder. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Remove useless code. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/swarming/deterministic_build.py
diff --git a/scripts/slave/recipes/swarming/deterministic_build.py b/scripts/slave/recipes/swarming/deterministic_build.py
index fcb8f48694f7a6320aa55a1968c073d7d8403bfb..5d51ac27cd73cce5a2656cfac7dc7ef663fbec30 100644
--- a/scripts/slave/recipes/swarming/deterministic_build.py
+++ b/scripts/slave/recipes/swarming/deterministic_build.py
@@ -34,18 +34,6 @@ DETERMINISTIC_BUILDERS = freeze({
'platform': 'linux',
'targets': ['all'],
},
- 'IOS deterministic build': {
- 'chromium_apply_config': ['ninja'],
- 'chromium_config': 'chromium_ios_device',
- 'chromium_config_kwargs': {
- 'BUILD_CONFIG': 'Release',
- 'TARGET_PLATFORM': 'ios',
- 'TARGET_BITS': 32,
- },
- 'gclient_config': 'ios',
- 'platform': 'mac',
- 'targets': ['all'],
- },
'Linux deterministic build': {
'chromium_config': 'chromium',
'gclient_config': 'chromium',
@@ -81,8 +69,6 @@ def ConfigureChromiumBuilder(api, recipe_config):
**recipe_config.get('chromium_config_kwargs',
{'BUILD_CONFIG': 'Release'}))
api.chromium.apply_config('chromium_deterministic_build')
- for c in recipe_config.get('chromium_apply_config', []):
- api.chromium.apply_config(c)
api.gclient.set_config(recipe_config['gclient_config'],
**recipe_config.get('gclient_config_kwargs', {}))
@@ -114,8 +100,7 @@ def GenSteps(api):
else:
target_platform = recipe_config.get('platform')
- # TODO(sebmarchand): iOS should be handled differently, fix this.
- if target_platform in ('linux', 'mac', 'win', 'ios'):
+ if target_platform in ('linux', 'mac', 'win'):
ConfigureChromiumBuilder(api, recipe_config)
elif target_platform is 'android':
ConfigureAndroidBuilder(api, recipe_config)

Powered by Google App Engine
This is Rietveld 408576698