[es6] implement default/optional parameters (WIP / comments)

src/ast-numbering.cc

Index: src/ast-numbering.cc
diff --git a/src/ast-numbering.cc b/src/ast-numbering.cc
index 1d5420990fc8d150f1999d9cc8607653afdc7037..80c238750998abbebf25ed0d27567688eb167932 100644
--- a/src/ast-numbering.cc
+++ b/src/ast-numbering.cc
@@ -523,6 +523,10 @@ void AstNumberingVisitor::VisitArguments(ZoneList<Expression*>* arguments) {
 void AstNumberingVisitor::VisitFunctionLiteral(FunctionLiteral* node) {
   IncrementNodeCount();
   node->set_base_id(ReserveIdRange(FunctionLiteral::num_ids()));
+  if (node->default_values()->length()) {
+    VisitArguments(node->default_values());

[arv (Not doing code reviews), 2015/04/10 15:08:48]

How are the default_values arguments?

[caitp (gmail), 2015/04/10 15:28:00]

They aren't, VisitArguments() will visit each element of a ZoneList<Expression*>
though. I think VisitExpressions() would also work. Either way, the numbering is
broken right now, I need a bit of help with that. (noted in comment, nothing in
the graph seems to have IDs set up at the time EmitInitializeOptionalParameters
is called, so it will break if the default value is anything complicated)

+  }
+
   // We don't recurse into the declarations or body of the function literal:
   // you have to separately Renumber() each FunctionLiteral that you compile.
 }