[es6] implement default/optional parameters (WIP / comments)

src/ast-numbering.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/ast.h"
 #include "src/ast-numbering.h"
 #include "src/scopes.h"
 
@@ skipping 505 matching lines @@
 void AstNumberingVisitor::VisitArguments(ZoneList<Expression*>* arguments) {
   for (int i = 0; i < arguments->length(); i++) {
     Visit(arguments->at(i));
   }
 }
 
 
 void AstNumberingVisitor::VisitFunctionLiteral(FunctionLiteral* node) {
   IncrementNodeCount();
   node->set_base_id(ReserveIdRange(FunctionLiteral::num_ids()));
+  if (node->default_values()->length()) {
+    VisitArguments(node->default_values());

[arv (Not doing code reviews), 2015/04/10 15:08:48]

How are the default_values arguments?

[caitp (gmail), 2015/04/10 15:28:00]

They aren't, VisitArguments() will visit each element of a ZoneList<Expression*>
though. I think VisitExpressions() would also work. Either way, the numbering is
broken right now, I need a bit of help with that. (noted in comment, nothing in
the graph seems to have IDs set up at the time EmitInitializeOptionalParameters
is called, so it will break if the default value is anything complicated)

+  }
+
   // We don't recurse into the declarations or body of the function literal:
   // you have to separately Renumber() each FunctionLiteral that you compile.
 }
 
 
 bool AstNumberingVisitor::Finish(FunctionLiteral* node) {
   node->set_ast_properties(&properties_);
   node->set_dont_optimize_reason(dont_optimize_reason());
   return !HasStackOverflow();
 }
@@ skipping 23 matching lines @@
 }
 
 
 bool AstNumbering::Renumber(Isolate* isolate, Zone* zone,
                             FunctionLiteral* function) {
   AstNumberingVisitor visitor(isolate, zone);
   return visitor.Renumber(function);
 }
 }
 }  // namespace v8::internal