Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(49)

Issue 10537124: Fix build with disabled NaCl glibc toolchain. (Closed)

Created:
7 years, 11 months ago by Paweł Hajdan Jr.
Modified:
7 years, 11 months ago
CC:
chromium-reviews, bradnelson
Visibility:
Public.

Description

Fix build with disabled NaCl glibc toolchain. This is upstreaming Gentoo Linux patch. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143364

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M build/common.gypi View 1 1 chunk +7 lines, -0 lines 0 comments Download
M ppapi/ppapi_untrusted.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Paweł Hajdan Jr.
Please review: viettrungluu (OWNERS) bradchen: FYI
7 years, 11 months ago (2012-06-12 14:27:22 UTC) #1
Brad Chen
Once the bots are green I will want to see that the glibc nacl tests ...
7 years, 11 months ago (2012-06-12 16:50:16 UTC) #2
Paweł Hajdan Jr.
On 2012/06/12 16:50:16, Brad Chen wrote: > Once the bots are green I will want ...
7 years, 11 months ago (2012-06-12 20:07:17 UTC) #3
viettrungluu
I know almost nothing about this, so if/when it's good enough for Brad, it'll be ...
7 years, 11 months ago (2012-06-12 20:18:37 UTC) #4
Brad Chen (chromium)
Let me know when you'd like me to have another look. On Tue, Jun 12, ...
7 years, 11 months ago (2012-06-12 20:29:34 UTC) #5
Paweł Hajdan Jr.
PTAL
7 years, 11 months ago (2012-06-20 09:22:11 UTC) #6
Brad Chen
LGTM
7 years, 11 months ago (2012-06-20 19:09:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/10537124/17001
7 years, 11 months ago (2012-06-21 06:28:58 UTC) #8
commit-bot: I haz the power
Presubmit check for 10537124-17001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2012-06-21 06:29:02 UTC) #9
Paweł Hajdan Jr.
This change has now landed. Brad, could you please remove definitions of gyp variable disable_glibc ...
7 years, 11 months ago (2012-06-21 10:29:53 UTC) #10
Brad Chen
I don't think we can do this as it would break the NaCl gyp build. ...
7 years, 11 months ago (2012-06-21 16:13:37 UTC) #11
Paweł Hajdan Jr.
+bradnelson On 2012/06/21 16:13:37, Brad Chen wrote: > I don't think we can do this ...
7 years, 11 months ago (2012-06-21 17:16:46 UTC) #12
bradn
So, why was this causing being in untrusted.gypi? It's got % after it and is ...
7 years, 11 months ago (2012-06-21 17:51:22 UTC) #13
Paweł Hajdan Jr.
On 2012/06/21 17:51:22, bradn wrote: > So, why was this causing being in untrusted.gypi? It's ...
7 years, 11 months ago (2012-06-21 18:03:00 UTC) #14
Brad Chen
This is a breaking change in NaCl because NaCl gyp does not depend on Chrome. ...
7 years, 11 months ago (2012-06-22 17:50:33 UTC) #15
bradn
7 years, 11 months ago (2012-06-23 01:02:20 UTC) #16
Ok, I've got a fix ready that will still gate this from untrusted.gypi, but
allow the condition you added to ppapi.
I need to run, but I'll send it out on monday.

-BradN


On Fri, Jun 22, 2012 at 10:50 AM, Brad Chen <bradchen@google.com> wrote:

> This is a breaking change in NaCl because NaCl gyp does not depend on
> Chrome. We are trying to eliminate the Chrome dependency in NaCl to
> eliminate a circular dependency.
>
> Maybe I need to figure out a change to native_client/build/common.gypi to
> complement your change in Chrome; I'll ask Brad about that.
>
> Cross compilation in GYP is generally a mess. Brad has some good ideas
> about making things better.
>
> Brad
>
>
> On Thu, Jun 21, 2012 at 10:16 AM, <phajdan.jr@chromium.org> wrote:
>
>> +bradnelson
>>
>>
>> On 2012/06/21 16:13:37, Brad Chen wrote:
>>
>>> I don't think we can do this as it would break the NaCl gyp build. If
>>> there is
>>>
>> a
>>
>>> bigger issue besides just the hygiene question we should consult with
>>> Brad
>>> Nelson as he has a better global grasp of gyp than I do.
>>>
>>
>> Are you sure that would be a breaking change? My understanding of gyp is
>> that
>> the definition from build/common.gypi will be used.
>>
>> I think it's more than a cosmetic issue - messy gyp files easily lead to
>> other
>> problems, and nacl ones are already complicated.
>>
>>
http://codereview.chromium.**org/10537124/<http://codereview.chromium.org/105...
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698