Add ability to CQ dry run patchsets during "git cl upload"

Add ability to CQ dry run patchsets during "git cl upload".

The corresponding Rietveld change is here: https://codereview.chromium.org/1054683003/

BUG=chromium:472690
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294699

[rmistry, 2015-04-01 18:48:38]

rmistry@google.com changed reviewers:
+ iannucci@chromium.org

[iannucci, 2015-04-01 23:13:03]

lgtm, though I'm assuming it's correct that both commit + dry_run bits need to
be set?

[rmistry, 2015-04-01 23:14:38]

On 2015/04/01 23:13:03, iannucci wrote:
> lgtm, though I'm assuming it's correct that both commit + dry_run bits need to
> be set?

Yes, both bits need to be set. The CQ checks the dry run bit to see that it is
in fact a dry run and then abandons the CL before committing.

[rmistry, 2015-04-02 11:49:41]

The Rietveld side change was submitted:
https://codereview.chromium.org/1054683003/

I will land this depot_tools change after the Rietveld change is live.

[rmistry, 2015-04-07 11:07:46]

On 2015/04/02 11:49:41, rmistry wrote:
> The Rietveld side change was submitted:
> https://codereview.chromium.org/1054683003/
> 
> I will land this depot_tools change after the Rietveld change is live.

The Rietveld change is live, landing this.

[rmistry, 2015-04-07 11:07:50]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2015-04-07 11:08:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1053653004/20001

[commit-bot: I haz the power, 2015-04-07 11:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-07 11:11:14]

Presubmit check for 1053653004-20001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_smoketest.py (53.79s) failed
Ffatal: reference is not a tree: c20a8732e01b7eaab8e8ed58bcac7611e5238c63
EE..............................................
======================================================================
ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest)
Like testBlinkDEPSChangeUsingGclient, but move the main project using
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1630, in testBlinkDEPSChangeUsingGit
    cwd=self.checkout_path)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
484, in check_call
    check_call_out(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
478, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git checkout -q
c20a8732e01b7eaab8e8ed58bcac7611e5238c63 returned non-zero exit status 128 in
/tmp/trialnRTfFC/__main__.BlinkDEPSTransitionSmokeTest.testBlinkDEPSChangeUsingGit/src

======================================================================
ERROR: testBlinkLocalBranchesArePreserved
(__main__.BlinkDEPSTransitionSmokeTest)
Checks that the state of local git branches are effectively preserved
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1656, in
testBlinkLocalBranchesArePreserved
    self.CheckStatusPreMergePoint()
  File "tests/gclient_smoketest.py", line 1558, in CheckStatusPreMergePoint
    self.blink), self.blink_git_url)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/scm.py", line
121, in Capture
    cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
515, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
475, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
449, in communicate
    proc = Popen(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
253, in __init__
    % (str(e), kwargs.get('cwd'), args[0]))
OSError: Execution failed with error: [Errno 2] No such file or directory:
'/tmp/trialnRTfFC/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit'.
Check that
/tmp/trialnRTfFC/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit
or git exist and have execution permission.

======================================================================
FAIL: testBlinkDEPSChangeUsingGclient (__main__.BlinkDEPSTransitionSmokeTest)
Checks that {src,blink} repos are consistent when syncing going back and
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1601, in
testBlinkDEPSChangeUsingGclient
    self.assertEqual(res[2], 0, 'DEPS change sync failed.')
AssertionError: DEPS change sync failed.

----------------------------------------------------------------------
Ran 49 tests in 53.592s

FAILED (failures=1, errors=2)


Presubmit checks took 189.1s to calculate.

[rmistry, 2015-04-07 11:11:53]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2015-04-07 11:11:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1053653004/20001

[commit-bot: I haz the power, 2015-04-07 11:15:03]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294699