Do not use GrBicubic effect when downscaling. Also, don't use glTexStorage as it interferes with de…

Do not use GrBicubic effect when downscaling. Also, don't use glTexStorage as it interferes with deleyed mipmap generation.

Committed: http://code.google.com/p/skia/source/detail?r=12576

[robertphillips, 2013-12-04 23:31:55]

lgtm

https://codereview.chromium.org/105353002/diff/20001/include/core/SkMatrix.h
File include/core/SkMatrix.h (right):

https://codereview.chromium.org/105353002/diff/20001/include/core/SkMatrix.h#...
include/core/SkMatrix.h:591: 
Don't think we want this extra space.

https://codereview.chromium.org/105353002/diff/20001/src/core/SkBitmapProcSha...
File src/core/SkBitmapProcShader.cpp (left):

https://codereview.chromium.org/105353002/diff/20001/src/core/SkBitmapProcSha...
src/core/SkBitmapProcShader.cpp:360: 
Why remove this stuff?

https://codereview.chromium.org/105353002/diff/20001/src/core/SkMatrix.cpp
File src/core/SkMatrix.cpp (right):

https://codereview.chromium.org/105353002/diff/20001/src/core/SkMatrix.cpp#ne...
src/core/SkMatrix.cpp:1894: // solve using quadratic equation (divisor is
non-zero since l^2 has 1 coeff
guaranteed

https://codereview.chromium.org/105353002/diff/20001/tests/MatrixTest.cpp
File tests/MatrixTest.cpp (right):

https://codereview.chromium.org/105353002/diff/20001/tests/MatrixTest.cpp#new...
tests/MatrixTest.cpp:151: rotate.setRotate(128 * SK_Scalar1);
Why not just check that they are close to 1?

[commit-bot: I haz the power, 2013-12-09 18:37:30]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/105353002/40001

[bsalomon, 2013-12-09 18:44:30]

https://codereview.chromium.org/105353002/diff/20001/include/core/SkMatrix.h
File include/core/SkMatrix.h (right):

https://codereview.chromium.org/105353002/diff/20001/include/core/SkMatrix.h#...
include/core/SkMatrix.h:591: 
On 2013/12/04 23:31:55, robertphillips wrote:
> Don't think we want this extra space.

Done.

https://codereview.chromium.org/105353002/diff/20001/src/core/SkBitmapProcSha...
File src/core/SkBitmapProcShader.cpp (left):

https://codereview.chromium.org/105353002/diff/20001/src/core/SkBitmapProcSha...
src/core/SkBitmapProcShader.cpp:360: 
On 2013/12/04 23:31:55, robertphillips wrote:
> Why remove this stuff?

It's from when SkShader lazily allocated and stored a matrix rather than just
always having a matrix and init'ing it to I. Both invert and perConcat have fast
paths for I.

https://codereview.chromium.org/105353002/diff/20001/src/core/SkMatrix.cpp
File src/core/SkMatrix.cpp (right):

https://codereview.chromium.org/105353002/diff/20001/src/core/SkMatrix.cpp#ne...
src/core/SkMatrix.cpp:1894: // solve using quadratic equation (divisor is
non-zero since l^2 has 1 coeff
On 2013/12/04 23:31:55, robertphillips wrote:
> guaranteed

Done.

https://codereview.chromium.org/105353002/diff/20001/tests/MatrixTest.cpp
File tests/MatrixTest.cpp (right):

https://codereview.chromium.org/105353002/diff/20001/tests/MatrixTest.cpp#new...
tests/MatrixTest.cpp:151: rotate.setRotate(128 * SK_Scalar1);
On 2013/12/04 23:31:55, robertphillips wrote:
> Why not just check that they are close to 1?

Done.

[commit-bot: I haz the power, 2013-12-09 19:16:12]

Change committed as 12576