Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 1053503002: [Fetch] Response.clone should tee the body stream. (Closed)

Created:
5 years, 8 months ago by yhirano
Modified:
5 years, 8 months ago
Reviewers:
horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Fetch] Response.clone() should tee the body stream. Previously Response.clone() does not refresh the body property and hence was not able to read data from the original response. This CL fixes the problem. BUG=435393 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192923

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -38 lines) Patch
M LayoutTests/http/tests/fetch/script-tests/request.js View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/response.js View 1 2 3 3 chunks +31 lines, -13 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/stream-reader.js View 1 2 3 1 chunk +21 lines, -5 lines 0 comments Download
M Source/modules/fetch/Body.h View 4 chunks +7 lines, -5 lines 0 comments Download
M Source/modules/fetch/Body.cpp View 4 chunks +13 lines, -6 lines 0 comments Download
M Source/modules/fetch/Request.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/fetch/Response.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/Cache.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
yhirano
5 years, 8 months ago (2015-04-01 02:56:41 UTC) #2
horo
lgtm
5 years, 8 months ago (2015-04-01 04:12:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053503002/60001
5 years, 8 months ago (2015-04-01 04:13:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/49915)
5 years, 8 months ago (2015-04-01 10:08:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053503002/60001
5 years, 8 months ago (2015-04-01 10:09:13 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 11:29:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192923

Powered by Google App Engine
This is Rietveld 408576698