Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1053123006: Calculate blocks needing a frame and frame (de)construction sites. (Closed)

Created:
5 years, 8 months ago by Sven Panne
Modified:
5 years, 7 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Calculate blocks needing a frame and frame (de)construction sites. Committed: https://crrev.com/bc7f79a67042de6255e09c984b4196f3eef6b2d6 Cr-Commit-Position: refs/heads/master@{#28120}

Patch Set 1 #

Patch Set 2 : Replaced DeConstruction with a simple bool. #

Patch Set 3 : Moved frame elision code into a class. #

Patch Set 4 : Removed Reversed part (landed in other CL) #

Patch Set 5 : Separate phase #

Patch Set 6 : Added missing files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -3 lines) Patch
M BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 1 2 3 4 1 chunk +6 lines, -2 lines 0 comments Download
A src/compiler/frame-elider.h View 1 2 3 4 5 1 chunk +41 lines, -0 lines 0 comments Download
A src/compiler/frame-elider.cc View 1 2 3 4 5 1 chunk +129 lines, -0 lines 0 comments Download
M src/compiler/instruction.h View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M src/compiler/instruction.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 2 3 4 4 chunks +15 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sven Panne
Just as a basis for discussions/initial feedback about the approach. We need to move this ...
5 years, 8 months ago (2015-04-17 11:58:38 UTC) #2
Sven Panne
PTAL, as discussed offline: Let's land this first and add the spill marking phase in ...
5 years, 7 months ago (2015-04-28 14:00:12 UTC) #3
dcarney
lgtm
5 years, 7 months ago (2015-04-28 15:08:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053123006/100001
5 years, 7 months ago (2015-04-29 05:53:22 UTC) #6
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-04-29 05:54:47 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 05:55:05 UTC) #8
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/bc7f79a67042de6255e09c984b4196f3eef6b2d6
Cr-Commit-Position: refs/heads/master@{#28120}

Powered by Google App Engine
This is Rietveld 408576698