Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1053123003: [menu.js] Menu.menuItemSelector has to be set before decoration (Closed)

Created:
5 years, 8 months ago by yoshiki
Modified:
5 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, estade+watch_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[menu.js] Menu.menuItemSelector has to be set before decoration In menu.js, the Menu.menuItemSelector is refereed in the decorator, so we need to set it before decoration BUG=none TEST=manually tested Committed: https://crrev.com/652ac00b6cb87ed4194fb47e651f4551b9b56d84 Cr-Commit-Position: refs/heads/master@{#323889}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M chrome/browser/resources/ntp4/other_sessions.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/gear_menu.js View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/main.html View 1 chunk +2 lines, -1 line 0 comments Download
M ui/webui/resources/js/cr/ui/menu.js View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yoshiki
@dbeam, I found the bug that some properties for menu is assigned to non-menu element. ...
5 years, 8 months ago (2015-04-03 14:08:30 UTC) #2
Dan Beam
lgtm
5 years, 8 months ago (2015-04-03 21:08:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053123003/20001
5 years, 8 months ago (2015-04-06 01:26:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-06 02:16:12 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 02:17:01 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/652ac00b6cb87ed4194fb47e651f4551b9b56d84
Cr-Commit-Position: refs/heads/master@{#323889}

Powered by Google App Engine
This is Rietveld 408576698