chrome/browser/resources/ntp4/other_sessions.js - Issue 1053123003: [menu.js] Menu.menuItemSelector has to be set before decoration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/ntp4/other_sessions.js

Issue 1053123003: [menu.js] Menu.menuItemSelector has to be set before decoration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/ntp4/other_sessions.js

diff --git a/chrome/browser/resources/ntp4/other_sessions.js b/chrome/browser/resources/ntp4/other_sessions.js

index 780ad79e91d728782418809a71755a49386fb783..bc1181850826548f660cb241b7a6e0b520613521 100644

--- a/chrome/browser/resources/ntp4/other_sessions.js

+++ b/chrome/browser/resources/ntp4/other_sessions.js

@@ -72,8 +72,8 @@ cr.define('ntp', function() {

decorate: function() {

MenuButton.prototype.decorate.call(this);

this.menu = new Menu;

+ this.menu.menuItemSelector = '[role=menuitem]'; // before decoration

cr.ui.decorate(this.menu, Menu);

- this.menu.menuItemSelector = '[role=menuitem]';

this.menu.classList.add('footer-menu');

this.menu.addEventListener('contextmenu',

this.onContextMenu_.bind(this), true);

« no previous file with comments | « no previous file | ui/file_manager/file_manager/foreground/js/ui/gear_menu.js » ('j') | no next file with comments »