Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: media/base/video_renderer_sink.h

Issue 1053113002: Prime the landing pad for the new video rendering pipeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments. Revert canvas changes. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/video_renderer.h ('k') | media/blink/video_frame_compositor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_renderer_sink.h
diff --git a/media/base/video_renderer_sink.h b/media/base/video_renderer_sink.h
new file mode 100644
index 0000000000000000000000000000000000000000..acb339c3194e6ab646aca485bd5d4b585902222c
--- /dev/null
+++ b/media/base/video_renderer_sink.h
@@ -0,0 +1,66 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_BASE_VIDEO_RENDERER_SINK_H_
+#define MEDIA_BASE_VIDEO_RENDERER_SINK_H_
+
+#include <vector>
+
+#include "base/basictypes.h"
+#include "base/logging.h"
+#include "media/base/media_export.h"
+#include "media/base/video_frame.h"
+
+namespace media {
+
+// VideoRendererSink is an interface representing the end-point for rendered
+// video frames. An implementation is expected to periodically call Render() on
+// a callback object.
+class MEDIA_EXPORT VideoRendererSink {
+ public:
+ class RenderCallback {
+ public:
+ // Returns a VideoFrame for rendering which should be displayed within the
+ // presentation interval [|deadline_min|, |deadline_max|]. Returns NULL if
+ // no frame or no new frame (since the last Render() call) is available for
+ // rendering within the requested interval. Intervals are expected to be
+ // regular, contiguous, and monotonically increasing. Irregular intervals
+ // may affect the rendering decisions made by the underlying callback.
+ virtual scoped_refptr<VideoFrame> Render(base::TimeTicks deadline_min,
DaleCurtis 2015/04/07 19:58:45 Since VideoFrameCompositor will need to pump and t
+ base::TimeTicks deadline_max) = 0;
+
+ // Called by the sink when a VideoFrame previously returned via Render() was
+ // not actually rendered. Must be called before the next Render() call.
+ virtual void OnFrameDropped() = 0;
+
+ // Render() callbacks may be suspended for compositing reasons. There will
DaleCurtis 2015/04/07 19:58:45 As discussed offline, these don't work since Video
+ // be no outstanding Render() callbacks when OnRenderSuspended() is called,
+ // nor any issued until after OnRenderResumed() has returned.
+ virtual void OnRenderResumed() = 0;
+ virtual void OnRenderSuspended() = 0;
+
+ virtual ~RenderCallback() {}
+ };
+
+ // Starts video rendering. See RenderCallback for more details.
+ virtual void Start(RenderCallback* callback) = 0;
+
+ // Stops video rendering, waits for any outstanding calls to |callback| to
+ // complete before returning. No new calls to |callback| will be issued after
+ // this method returns.
+ virtual void Stop() = 0;
+
+ // Instead of using a callback driven rendering path, allow clients to paint
+ // frames as they see fit without regard for the compositor.
+ // TODO(dalecurtis): This should be nuked once experiments show the new path
+ // is amazing and the old path is not! http://crbug.com/439548
+ virtual void PaintFrameUsingOldRenderingPath(
+ const scoped_refptr<VideoFrame>& frame) = 0;
+
+ virtual ~VideoRendererSink() {}
+};
+
+} // namespace media
+
+#endif // MEDIA_BASE_VIDEO_RENDERER_SINK_H_
« no previous file with comments | « media/base/video_renderer.h ('k') | media/blink/video_frame_compositor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698