src/compiler/linkage.cc - Issue 1053063003: Make --always-opt also optimize top-level code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/linkage.cc

Issue 1053063003: Make --always-opt also optimize top-level code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Skip failing tests. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/linkage.cc

diff --git a/src/compiler/linkage.cc b/src/compiler/linkage.cc

index 72b7dafe9801531c85ab648bf06f843fc4dee2d2..a16f96ff4df851242ef04c751e5ba28f82e2a013 100644

--- a/src/compiler/linkage.cc

+++ b/src/compiler/linkage.cc

@@ -104,7 +104,6 @@ bool Linkage::NeedsFrameState(Runtime::FunctionId function) {

// not to call into arbitrary JavaScript, not to throw, and not to deoptimize

// are blacklisted here and can be called without a FrameState.

switch (function) {

- case Runtime::kDeclareGlobals: // TODO(jarin): Is it safe?

case Runtime::kDefineClassMethod: // TODO(jarin): Is it safe?

case Runtime::kDefineGetterPropertyUnchecked: // TODO(jarin): Is it safe?

case Runtime::kDefineSetterPropertyUnchecked: // TODO(jarin): Is it safe?