Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: src/hydrogen.cc

Issue 1053063003: Make --always-opt also optimize top-level code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Skip failing tests. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index 40f0ca4601a59e439c4f2229fabe3f4c045b3f10..0e980b24cca16d582cd9fd62e00cb0db505b8e54 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -4221,6 +4221,11 @@ bool HOptimizedGraphBuilder::BuildGraph() {
return false;
}
+ if (current_info()->scope()->is_script_scope()) {
+ Bailout(kScriptContext);
+ return false;
Toon Verwaest 2015/04/07 20:55:05 Doesn't this entirely disable top-level OSR? If I
Michael Starzinger 2015/04/07 23:01:03 It might be that this needs to be guarded by an ad
Michael Starzinger 2015/04/08 12:29:18 For the record, addressed by: https://codereview.c
+ }
+
Scope* scope = current_info()->scope();
SetUpScope(scope);
@@ -11436,7 +11441,7 @@ void HOptimizedGraphBuilder::VisitFunctionDeclaration(
void HOptimizedGraphBuilder::VisitModuleDeclaration(
ModuleDeclaration* declaration) {
- UNREACHABLE();
+ return Bailout(kModuleDeclaration);
}
« no previous file with comments | « src/factory.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | test/mozilla/mozilla.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698