Issue 1053013009: Make MediaStreamBufferManager.General pass in official builds.

Issue 1053013009: Make MediaStreamBufferManager.General pass in official builds. (Closed)

Created:
5 years, 8 months ago by Nico

Modified:
5 years, 8 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Make MediaStreamBufferManager.General pass in official builds. BUG=474410 Committed: https://crrev.com/53a47ba48829ee485f3fd88a52cfe2ca33eca494 Cr-Commit-Position: refs/heads/master@{#324051}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	ppapi/shared_impl/media_stream_buffer_manager_unittest.cc	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

Nico

Alternatively, we could always use "". Not sure how much checking these strings adds.

5 years, 8 months ago (2015-04-07 01:05:50 UTC) #2

dmichael (off chromium)

Hmm, yeah, tempting to say go the simpler way ("" or ".*"). But I guess ...

5 years, 8 months ago (2015-04-07 15:27:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1053013009/20001

5 years, 8 months ago (2015-04-07 16:11:00 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-07 16:15:54 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/53a47ba48829ee485f3fd88a52cfe2ca33eca494
Cr-Commit-Position: refs/heads/master@{#324051}