DescriptionRevert of Use enum BinaryType for WebSocket.binaryType, instead of DOMString (patchset #7 id:120001 of https://codereview.chromium.org/871013007/)
Reason for revert:
Failing in gtests:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8/builds/35898/steps/webkit_unit_tests/logs/DOMWebSocketDeathTest.binaryType
[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 5 threads.
../../third_party/WebKit/Source/modules/websockets/DOMWebSocketTest.cpp:687: Failure
Death test: m_websocket->setBinaryType("hoge")
Result: failed to die.
Error msg:
[ DEATH ]
[ FAILED ] DOMWebSocketDeathTest.binaryType (5 ms)
Original issue's description:
> This addresses a FIXME in WebSocket.idl
>
> Also removing logging for wrong value as now we are logging in binding code:
> https://codereview.chromium.org/955413002/.
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193201
TBR=habib.virji@samsung.com,nbarth@chromium.org,yutak@chromium.org,tyoshino@chromium.org,haraken@chromium.org,bashi@chromium.org,paritosh.in@samsung.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193206
Patch Set 1 #
Created: 5 years, 8 months ago
(Patch set is too large to download)
Messages
Total messages: 6 (0 generated)
|