Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1052993002:
Change V8 to branch 4.3 for M43 (Closed)
|
Created:
5 years, 8 months ago by Michael Hablich Modified:
5 years, 8 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange V8 to branch 4.3 for M43
R=jkummerov@chromium.org, machenbach@chromium.org
BUG=
Committed: https://crrev.com/cf39a715ec1652ef4468cc0daa72f6709f735465
Cr-Commit-Position: refs/heads/master@{#323515}
Patch Set 1 #Patch Set 2 : Change commit to the one from heads #Messages
Total messages: 29 (6 generated)
hablich@chromium.org changed reviewers: + vogelheim@chromium.org
On 2015/04/02 13:44:30, Hablich wrote: Can it be that the trybots are not working when I add them manually?
You need to pin to the version where we branched from. I.e. f5c0a23a505616796a628d64f4ffe377d1fc4bcf
The CQ bit was checked by hablich@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052993002/20001
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by hablich@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052993002/20001
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052993002/20001
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052993002/20001
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052993002/20001
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052993002/20001
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052993002/20001
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052993002/20001
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052993002/20001
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052993002/20001
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052993002/20001
The CQ bit was unchecked by commit-bot@chromium.org
This issue passed the CQ dry run.
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052993002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1051243003/ by mfomitchev@chromium.org. The reason for reverting is: There is a compile failure on WebKit Win Builder (dbg) http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%2... All other CLs that went in look fairly innocuous, this is the only one that looks suspect, so I am going to revert. Apologies if this is a mistake..
Message was sent while issue was closed.
On 2015/04/02 17:32:05, mfomitchev wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/1051243003/ by mailto:mfomitchev@chromium.org. > > The reason for reverting is: There is a compile failure on WebKit Win Builder > (dbg) > http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%2... > > All other CLs that went in look fairly innocuous, this is the only one that > looks suspect, so I am going to revert. Apologies if this is a mistake.. The Blink patch that caused that build error (r193045) has already been reverted, in r193045, so this can safely be re-landed.
Message was sent while issue was closed.
On 2015/04/02 17:51:41, adamk wrote: > On 2015/04/02 17:32:05, mfomitchev wrote: > > A revert of this CL (patchset #2 id:20001) has been created in > > https://codereview.chromium.org/1051243003/ by mailto:mfomitchev@chromium.org. > > > > The reason for reverting is: There is a compile failure on WebKit Win Builder > > (dbg) > > > http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%2... > > > > All other CLs that went in look fairly innocuous, this is the only one that > > looks suspect, so I am going to revert. Apologies if this is a mistake.. > > The Blink patch that caused that build error (r193045) has already been > reverted, in r193045, so this can safely be re-landed. I am relanding in https://codereview.chromium.org/1058943003
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/cf39a715ec1652ef4468cc0daa72f6709f735465 Cr-Commit-Position: refs/heads/master@{#323515} |
