Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1058943003: Change V8 to branch 4.3 for M43 (Closed)

Created:
5 years, 8 months ago by adamk
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change V8 to branch 4.3 for M43 This is a reland of the previous roll (crrev.com/1052993002) which got reverted due to an errant Blink change that depended on a newer version of the V8 API. That Blink change has since been reverted. R=hablich@chromium.org, machenbach@chromium.org TBR=hablich@chromium.org, machenbach@chromium.org, vogelheim@chromium.org Committed: https://crrev.com/81d4867666467192685ae572de885796fe79c39a Cr-Commit-Position: refs/heads/master@{#323572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058943003/1
5 years, 8 months ago (2015-04-02 18:09:21 UTC) #2
Michael Hablich
On 2015/04/02 18:09:21, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 8 months ago (2015-04-02 18:13:33 UTC) #3
Michael Achenbach
lgtm
5 years, 8 months ago (2015-04-02 18:54:36 UTC) #4
adamk
Committed patchset #1 (id:1) manually as 81d4867666467192685ae572de885796fe79c39a (presubmit successful).
5 years, 8 months ago (2015-04-02 22:34:16 UTC) #5
alph
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1059633003/ by alph@chromium.org. ...
5 years, 8 months ago (2015-04-03 07:04:43 UTC) #6
Michael Hablich
On 2015/04/03 07:04:43, alph wrote: > A revert of this CL (patchset #1 id:1) has ...
5 years, 8 months ago (2015-04-03 10:12:15 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:29:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81d4867666467192685ae572de885796fe79c39a
Cr-Commit-Position: refs/heads/master@{#323572}

Powered by Google App Engine
This is Rietveld 408576698