Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 105293003: Disable media_cns_cases on ANDROID, make it DESKTOP only test. (Closed)

Created:
7 years ago by shadi
Modified:
7 years ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Disable media_cns_cases on ANDROID, make it DESKTOP only test. BUG=326154 NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=240510

Patch Set 1 #

Patch Set 2 : disable media_perftests on android #

Patch Set 3 : revert disable media_perftests on android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M masters/master.chromium.perf/master.cfg View 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
shadi
This will enable the test on Linux (see https://codereview.chromium.org/100513005/). PTAL
7 years ago (2013-12-10 01:34:44 UTC) #1
tonyg
lgtm assuming that you are indicating that this test doesn't make sense on android. stip ...
7 years ago (2013-12-10 01:36:50 UTC) #2
shadi
Need OWNER's lgtm, stip? tonyg@: it does make sense on android except that the test ...
7 years ago (2013-12-10 01:39:18 UTC) #3
shadi1
Disabling media_perftests on Android as well.
7 years ago (2013-12-10 03:03:39 UTC) #4
tonyg
still lgtm stip?
7 years ago (2013-12-10 03:46:32 UTC) #5
rileya (GONE FROM CHROMIUM)
The media_perftests issue should be fixed with https://codereview.chromium.org/111293002/ so provided that lands, I think it ...
7 years ago (2013-12-10 04:32:42 UTC) #6
shadi1
Removing "disable media_perftests" as they have been fixed in https://codereview.chromium.org/111293002
7 years ago (2013-12-10 23:58:34 UTC) #7
shadi1
stip: can you PTAL
7 years ago (2013-12-11 21:23:49 UTC) #8
ghost stip (do not use)
lgtm, sorry this slipped by somehow
7 years ago (2013-12-12 23:56:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/105293003/60001
7 years ago (2013-12-13 00:40:09 UTC) #10
commit-bot: I haz the power
Presubmit check for 105293003-60001 failed and returned exit status 1. Running presubmit commit checks ...
7 years ago (2013-12-13 00:40:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/105293003/60001
7 years ago (2013-12-13 01:45:56 UTC) #12
commit-bot: I haz the power
7 years ago (2013-12-13 01:46:24 UTC) #13
Message was sent while issue was closed.
Change committed as 240510

Powered by Google App Engine
This is Rietveld 408576698