Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1052903002: Migrate vr to use inlined tracing (Closed)

Created:
5 years, 8 months ago by jaemin.moon
Modified:
5 years, 8 months ago
CC:
blink-reviews, gyuyoung2
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

InlinedVisitor: Migrate vr to use inlined tracing BUG=455524 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193005

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M Source/modules/vr/HMDVRDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/HMDVRDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/NavigatorVRDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/NavigatorVRDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/PositionSensorVRDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/PositionSensorVRDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VRDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VRDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VREyeParameters.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VREyeParameters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VRHardwareUnit.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VRHardwareUnit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VRPositionState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vr/VRPositionState.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
jaemin.moon
Hi. I modified trace() method for Oilpan. Could you check this please?
5 years, 8 months ago (2015-04-02 06:03:59 UTC) #3
haraken
LGTM
5 years, 8 months ago (2015-04-02 06:05:40 UTC) #4
bajones
LGTM
5 years, 8 months ago (2015-04-02 06:06:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052903002/1
5 years, 8 months ago (2015-04-02 06:08:13 UTC) #7
kouhei (in TOK)
lgtm
5 years, 8 months ago (2015-04-02 06:08:49 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 07:25:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193005

Powered by Google App Engine
This is Rietveld 408576698